Skip to content
Snippets Groups Projects
  1. Apr 17, 2020
    • Arthur O'Dwyer's avatar
      VariadicMatcher needs a non-defaulted move constructor for compile-time performance. · 4f002f1e
      Arthur O'Dwyer authored
      We are about to remove all uses of GTEST_DISALLOW_ASSIGN_ in favor
      of using the Rule of Zero everywhere.
      
      Unfortunately, if we use the Rule of Zero here, then when the compiler
      needs to figure out if VariadicMatcher is move-constructible, it will
      recurse down into `tuple<Args...>`, which on libstdc++ recurses too deeply.
      
          In file included from googlemock/test/gmock-matchers_test.cc:43:
          In file included from googlemock/include/gmock/gmock-matchers.h:258:
          In file included from /usr/include/c++/5.5.0/algorithm:60:
          In file included from /usr/include/c++/5.5.0/utility:70:
          In file included from /usr/include/c++/5.5.0/bits/stl_pair.h:59:
          In file included from /usr/include/c++/5.5.0/bits/move.h:57:
          /usr/bin/include/c++/5.5.0/type_traits:115:26: fatal error:
                recursive template instantiation exceeded maximum depth of 256
              : public conditional<_B1::value, _B1, _B2>::type
                                   ^
      
      The move constructor is the only problematic case, for some unknown reason.
      With GTEST_DISALLOW_ASSIGN_, the presence of a copy assignment operator
      causes the move constructor to be non-declared, thus non-defaulted, thus
      non-problematic. Without GTEST_DISALLOW_ASSIGN_, we have to do one of the
      following:
      
      - Default the copy constructor, so that the move constructor will be non-declared.
      
      - Define our own non-defaulted move constructor.
      
      ...except that doing the latter STILL did not work!
      Fortunately, the former (default the copy constructor, don't provide
      any move constructor) both works in practice and is semantically
      equivalent to the old code.
      4f002f1e
    • Abseil Team's avatar
      Googletest export · 373d72b6
      Abseil Team authored
      Fix link to "After clause". Sorry, reader, but this heading is in another document!
      
      PiperOrigin-RevId: 305947971
      373d72b6
  2. Apr 01, 2020
    • Abseil Team's avatar
      Googletest export · 61f010d7
      Abseil Team authored
      Do not use std::result_of as it was removed in C++20.
      
      PiperOrigin-RevId: 303783600
      61f010d7
  3. Mar 21, 2020
  4. Mar 18, 2020
  5. Feb 29, 2020
    • Abseil Team's avatar
      Googletest export · 909b1ccf
      Abseil Team authored
      Relax the implementation of MatcherCast to allow conversion of `Matcher<T>` to
      `Matcher<const T&>`. They have the same match signature.
      
      PiperOrigin-RevId: 297115843
      909b1ccf
    • Abseil Team's avatar
      Googletest export · fd538161
      Abseil Team authored
      Allow construction of an Action from a callable of zero args
      
      Action already allows construction from a callable with the same args as the mocked function, without needing to wrap the callable in Invoke. However, if you don't care about the arguments to the mocked function you need to either accept all of them or wrap your callable in InvokeWithoutArgs. This change makes both of those unnecessary, since it allows you to pass a no-args callable to Action directly.
      
      PiperOrigin-RevId: 296117034
      fd538161
  6. Feb 12, 2020
    • Abseil Team's avatar
      Googletest export · 6f5fd0d7
      Abseil Team authored
      Add gmock Matcher<std::string_view> specialization.
      
      PiperOrigin-RevId: 294443240
      6f5fd0d7
    • Abseil Team's avatar
      Googletest export · d0930731
      Abseil Team authored
      Fix gmock_gen to use MOCK_METHOD instead of old style macros.  Fix several
      related bugs in argument parsing and return types.
      - handle commas more correctly in return types
      - handle commas correctly in arguments
      - handle default values more correctly
      
      PiperOrigin-RevId: 294435093
      d0930731
    • Abseil Team's avatar
      Googletest export · 56de7cc8
      Abseil Team authored
      Fix gmock_gen to use MOCK_METHOD instead of old style macros.
      
      PiperOrigin-RevId: 294360947
      56de7cc8
    • Abseil Team's avatar
      Googletest export · 360f5f70
      Abseil Team authored
      Fix gmock_gen to use MOCK_METHOD instead of old style macros.
      
      PiperOrigin-RevId: 294332975
      360f5f70
  7. Feb 08, 2020
    • Abseil Team's avatar
      Googletest export · 41b5f149
      Abseil Team authored
      Get rid of gmock-generated-matchers.h and gmock-generated-matchers.h.pump.
      
      Stop using pump for MATCHER* macroses generation.
      
      PiperOrigin-RevId: 293878808
      41b5f149
    • durandal's avatar
      Googletest export · 2d6d7a01
      durandal authored
      Tag the function generated by MATCHER with GTEST_ATTRIBUTE_UNUSED_ to fix CI builds of gmock-matchers_test.cc vs. -Wunused-function.
      
      See https://github.com/google/googletest/pull/2697 for breakage.
      
      PiperOrigin-RevId: 293669752
      2d6d7a01
    • Abseil Team's avatar
      Googletest export · fbf67a70
      Abseil Team authored
      Get rid of gmock-generated-function-mockers.h and
      gmock-generated-function-mockers.h.pump.
      
      Stop using pump for GMOCK_METHOD* macroses generation.
      
      PiperOrigin-RevId: 293454519
      fbf67a70
    • Abseil Team's avatar
      Googletest export · 11d9834e
      Abseil Team authored
      ...text exposed to GitHub repo https://www.github.com/google/googletest
      
      PiperOrigin-RevId: 293438092
      11d9834e
    • Abseil Team's avatar
      Googletest export · d02e2772
      Abseil Team authored
      Pass method's parameters count to internal GMOCK_METHOD* macro.
      
      This will help removing copypaste in every GMOCK_METHOD* macro in future.
      
      PiperOrigin-RevId: 292932554
      d02e2772
    • Abseil Team's avatar
      Googletest export · 4f660912
      Abseil Team authored
      Fix std::move to std::forward where appropriate to support reference types.
      
      PiperOrigin-RevId: 292923058
      4f660912
    • Abseil Team's avatar
      Googletest export · 572e261b
      Abseil Team authored
      Fix use of reserved names.
      Minimize code duplication needed for explict-vs-nonexplicit constructor.
      
      PiperOrigin-RevId: 292555014
      572e261b
    • Abseil Team's avatar
      Googletest export · 38f6608e
      Abseil Team authored
      Add includes for type_traits and utility to gmock-function-mocker.h: macros in the file require these headers.
      
      PiperOrigin-RevId: 291782497
      38f6608e
    • Abseil Team's avatar
      Googletest export · d6ce39ed
      Abseil Team authored
      Create implementation macroses for matchers to move variadic parameters to the
      end of parameters list.
      
      To save backward compatibility, old macroses will be still taking `description`
      parameter as the last one. But they will use INTERNAL macro that takes
      `description` as the second parameter.
      
      PiperOrigin-RevId: 291724469
      d6ce39ed
    • Abseil Team's avatar
      Googletest export · 87061810
      Abseil Team authored
      Move part of functionality of Matcher* class to the base one. Reduce copypaste.
      
      Make constructor and conversion operator of Matcher* class independent of pump.
      
      PiperOrigin-RevId: 291405510
      87061810
    • Abseil Team's avatar
      Googletest export · 22397f28
      Abseil Team authored
      Add missing explicit keyword for gmock_Impl constructor.
      
      When switching to using GMOCK_PP in ACTION* macroses `explicit` keyword was
      missed in gmock_Impl constructor causing ClangTidy warnings in ACTION_P macro.
      
      PiperOrigin-RevId: 291159975
      22397f28
  8. Jan 22, 2020
    • Abseil Team's avatar
      Googletest export · d01e356e
      Abseil Team authored
      Allow copying of the string in MatchAndExplain.
      
      Otherwise, conversions from std::string_view to std::string will fail as being
      explicit
      
      PiperOrigin-RevId: 290301103
      d01e356e
  9. Jan 17, 2020
    • Abseil Team's avatar
      Googletest export · 5336106b
      Abseil Team authored
      Use GMOCK_PP to create GMOCK_INTERNAL_ACTION macro.
      
      Create GMOCK_INTERNAL_ACTION macro that generates ACTION_P* macroses using
      GMOCK_PP.
      
      PiperOrigin-RevId: 289815906
      5336106b
    • Abseil Team's avatar
      Googletest export · 7a8591e6
      Abseil Team authored
      Use GMOCK_PP to generate args boilerplate.
      
      Move common args describing part to separate macroses that uses GMOCK_PP to
      generate sequences.
      
      PiperOrigin-RevId: 289655624
      7a8591e6
  10. Jan 13, 2020
  11. Jan 10, 2020
    • Abseil Team's avatar
      Googletest export · c901f67d
      Abseil Team authored
      Move part of functionality of Action* class to the base one. Reduce copypaste.
      
      Make constructor and conversion operator of Action* class independent of pump.
      
      PiperOrigin-RevId: 288907005
      c901f67d
    • Abseil Team's avatar
      Googletest export · 4b9c1691
      Abseil Team authored
      Use C++11 variadic templates for Invoke in gmock-generated-actions.h.
      
      Replace InvokeArgumentAdl with Invoke that uses C++11 variadic templates.
      
      PiperOrigin-RevId: 288449236
      4b9c1691
  12. Jan 03, 2020
    • Abseil Team's avatar
      Googletest export · 306f3754
      Abseil Team authored
      Explicitly default copy constructor in BoundSecondMatcher
      
      Since C++11, implicit defaulting of copy constructors is deprecated for types
      with user-defined copy assignment operators, so we should explicitly default the
      copy constructor of BoundSecondMatcher.
      
      PiperOrigin-RevId: 287587847
      306f3754
    • Abseil Team's avatar
      Googletest export · 153909f0
      Abseil Team authored
      Fix typo in example.
      
      PiperOrigin-RevId: 287212448
      153909f0
    • Abseil Team's avatar
      Googletest export · d0a52125
      Abseil Team authored
      Use C++11 variadic templates for InvokeArgumentAdl in gmock-generated-actions.h.
      
      Make InvokeArgumentAdl use variadic templates to generate its overloads instead
      of using pump.py syntax.
      
      PiperOrigin-RevId: 286267615
      d0a52125
    • Abseil Team's avatar
      Googletest export · 6f1a8ffd
      Abseil Team authored
      Use C++11 variadic templates for InvokeArgumentAdl in gmock-generated-actions.h.
      
      Make InvokeArgumentAdl use variadic templates to generate its overloads instead
      of using pump.py syntax.
      
      PiperOrigin-RevId: 286148805
      6f1a8ffd
  13. Dec 17, 2019
    • krzysio's avatar
      Googletest export · 0a0c8266
      krzysio authored
      Don't use fully qualified ::std types in code examples.
      
      Having a nested user-defined 'std' namespace anywhere in a program is a minefield and shouldn't be either explicitly supported or implicitly condoned.
      
      PiperOrigin-RevId: 285790182
      0a0c8266
  14. Dec 14, 2019
    • Abseil Team's avatar
      Googletest export · d8eeb976
      Abseil Team authored
      Use C++11 variadic templates for ActionHelper in gmock-generated-actions.h.
      
      Make ActionHelper use variadic templates to generate Perform static member function specializations instead of using pump.py syntax.
      
      PiperOrigin-RevId: 284988441
      d8eeb976
Loading