- Jun 05, 2020
-
-
Gennadiy Rozental authored
PiperOrigin-RevId: 314593695
-
Abseil Team authored
gMock Cookbook: Slight rewording Remove "I" because documentation can have multiple authors. And remove unnecessary "guy". PiperOrigin-RevId: 314533746
-
- Jun 03, 2020
-
-
Gennadiy Rozental authored
PiperOrigin-RevId: 314427570
-
Abseil Team authored
Note that EXPECT_EQ(actual_value, expected_value) or EXPECT_THAT(actual_value, Eq(expected_value)) is preferred over EXPECT_THAT(actual_value, expected_value). PiperOrigin-RevId: 314350852
-
Abseil Team authored
Modify NULL to nullptr in code examples PiperOrigin-RevId: 314150792
-
- May 29, 2020
-
-
Krystian Kuzniarek authored
-
Krystian Kuzniarek authored
-
Krystian Kuzniarek authored
-
Krystian Kuzniarek authored
-
dmauro authored
Update Travis CI to use Ubuntu Bionic in some cases PiperOrigin-RevId: 313639562
-
dmauro authored
Fix compile error from protected destructor of std::codecvt PiperOrigin-RevId: 313584603
-
Abseil Team authored
Change 'suite' to 'case' in comments. PiperOrigin-RevId: 313429487
-
Derek Mauro authored
PiperOrigin-RevId: 313386267
-
dmauro authored
Rollback of warning on unused ACTION result change PiperOrigin-RevId: 313380971
-
Derek Mauro authored
PiperOrigin-RevId: 313289519
-
Derek Mauro authored
PiperOrigin-RevId: 312530971
-
Derek Mauro authored
PiperOrigin-RevId: 312486861
-
Derek Mauro authored
PiperOrigin-RevId: 312342956
-
Abseil Team authored
Spell out namespace for absl::Notification. PiperOrigin-RevId: 312300192
-
Abseil Team authored
Addresses https://github.com/google/googletest/issues/2848 by using `_wfopen(...)` on Windows PiperOrigin-RevId: 312198825
-
durandal authored
Silence MSVC C4100 (unused formal parameter) to fix breakage from recently added testcase. This warning is silenced in many files throughout googletest, but was not needed here until this testcase was added. PiperOrigin-RevId: 312121200
-
Abseil Team authored
Mark ACTION_Pn()-generated functions as must-use-result. This catches when a client creates an action and discards it, thinking that the action has actually been applied to something. This will help people who make the mistake of defining, for example, both `void Use(Foo*)` and `ACTION(Use) { Use(arg); }` for later application to a Foo. With such an overload, a client may then write `Use();`, forgetting the param and being confused why nothing happens. This also catches when a client defines their own action in terms of an ACTION()-generated one, invokes the ACTION's builder, and then fails to invoke the resulting action, thinking it's operating on the outer action's parameters. PiperOrigin-RevId: 312108101
-
Abseil Team authored
Fix the ACTION* macros to allow for more than 10 arguments in the action. Only the first 10 will be passed as individual arguments as `argN`, but the rest can be accessed from the `args` tuple. PiperOrigin-RevId: 311542098
-
- May 25, 2020
-
-
ppenguin authored
-
- May 20, 2020
- May 14, 2020
-
-
Abseil Team authored
Remove broken URL. PiperOrigin-RevId: 311377660
-
Abseil Team authored
Fixed #2823 - Make it so that a semicolon appearing after an invocation of GTEST_SUPPRESS_UNREACHABLE_CODE_WARNING_BELOW_ does not trigger a redundant semicolon warning. This works by introducing an else block with a statement that intentionally does not end with a semicolon, forcing users to place the semicolon after the expansion. The approach here is preferred as opposed to removing semicolons that appear after each invocation because complete statements that do not have a visible semicolon or braces confuse users and code formatters, since the macro invocation looks superficially like an expression. PiperOrigin-RevId: 311327491
-
- May 13, 2020
-
-
Andy Getz authored
PiperOrigin-RevId: 310911989
-
Andy Getz authored
PiperOrigin-RevId: 310910168
-
Abseil Team authored
Addresses https://github.com/google/googletest/pull/2784 PiperOrigin-RevId: 310902202
-
- May 08, 2020
-
-
Martin Storsjö authored
The documentation for IsDebuggerPresent says that one just should include windows.h, as that one is an umbrella header that includes the header that declares IsDebuggerPresent. In older Windows SDKs, debugapi.h didn't exist and IsDebuggerPresent was declared in winbase.h (also included by windows.h). This should fix issue #2822 properly.
-
Martin Storsjö authored
This reverts commit a9f6c1ed. That commit cannot fix the issue it sets out to fix. The original issue, #2822, was that building with a toolset targeting XP compatibility is missing the debugapi.h header - as debugapi.h didn't exist in older Windows SDKs. Commit a9f6c1ed misinterpreted the Microsoft documentation about IsDebuggerPresent. The information about which header to use, "debugapi.h (include Windows.h)" means that the function declaration currently lives in debugapi.h, but for compatibility, just include the Windows.h umbrella header. In older Windows SDKs (e.g. the v6.0a SDK), IsDebuggerPresent is declared in winbase.h, and debugapi.h doesn't exist at all in those versions. Including Windows.h with a different capitalization than the existing include won't help finding headers that don't exist. Including Windows.h with a capital W breaks cross compilation with mingw toolchains, where the header always has been spelled with a lower case W. When building on native windows, the file system is case insensitive and the capitalization doesn't matter. This fixes issue #2840.
-
Abseil Team authored
Fix `-Wgnu-zero-variadic-macro-arguments` in GMock Passing zero arguments to the variadic part of a macro is a GNU extension and triggers warnings when build projects using GMock with `-pedantic`. - Fix uses of `GMOCK_PP_INTERNAL_16TH` to always receive at least 17 arguments. (this was triggered when `GMOCK_PP_NARG` or `GMOCK_PP_HAS_COMMA` were used with an argument containing no commas). - Fix `GMOCK_PP_HEAD` to append a dummy unused argument so that `GMOCK_PP_INTERNAL_HEAD` always has two arguments. PiperOrigin-RevId: 310414611
-
- May 06, 2020
-
-
vslashg authored
PiperOrigin-RevId: 309958629
-
vslashg authored
PiperOrigin-RevId: 309951872
-
Abseil Team authored
Addresses Github issue (https://github.com/google/googletest/issues/2822) by following the Microsoft documention (https://docs.microsoft.com/en-us/windows/win32/api/debugapi/nf-debugapi-isdebuggerpresent) to include capital-W Windows.h before including debugapi.h. See "Header debugapi.h (include Windows.h)" PiperOrigin-RevId: 309745868
-
- May 02, 2020
-
-
Abseil Team authored
Fix documentation. This address https://github.com/google/googletest/pull/2827. PiperOrigin-RevId: 309241571
-
Abseil Team authored
Fix link to "high-perf dependency injection technique". PiperOrigin-RevId: 308893893
-
Gennadiy Rozental authored
PiperOrigin-RevId: 308711492
-