Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
C
core
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Package registry
Container Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to JiHu GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Chenhao Ma
core
Commits
0e6066a4
Commit
0e6066a4
authored
8 years ago
by
Colton Leekley-Winslow
Browse files
Options
Downloads
Patches
Plain Diff
touch up pull request guidelines
parent
91e83a54
No related branches found
Branches containing commit
No related tags found
Tags containing commit
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
CONTRIBUTING.md
+2
-0
2 additions, 0 deletions
CONTRIBUTING.md
PULL_REQUEST_TEMPLATE.md
+5
-5
5 additions, 5 deletions
PULL_REQUEST_TEMPLATE.md
with
7 additions
and
5 deletions
CONTRIBUTING.md
+
2
−
0
View file @
0e6066a4
...
...
@@ -17,9 +17,11 @@ Then review and decide what upgrades to make, if any.
Changes to
`requirements.txt`
should always be by pull request.
## Code Standards
### Testing
-
Add tests for every change made
-
Tests should be realistic and exercise a wide range of possibilities
### Docstrings
-
Use
[
Google Style Docstrings
](
http://sphinxcontrib-napoleon.readthedocs.io/en/latest/example_google.html
)
.
-
Add docstrings to all functions with a one-line description of its purpose.
...
...
This diff is collapsed.
Click to expand it.
PULL_REQUEST_TEMPLATE.md
+
5
−
5
View file @
0e6066a4
###
Checklist
for Review
er(s)
###
Tips
for Review
-
[ ]
Tests were added to cover all code changed
-
[ ]
Documentation was added / updated
-
[ ]
Code and tests follow standards in CONTRIBUTING.md
-
[ ]
A detailed explanation of issues was given by the reviewer, using clear language and technical terms
-
Tests were added to cover all code changed
-
Documentation was added / updated
-
Code and tests follow standards in CONTRIBUTING.md
-
A detailed explanation of issues was given by the reviewer, using clear language and technical terms
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment