1. 15 Nov, 2014 6 commits
  2. 14 Nov, 2014 11 commits
    • Lukáš Lalinský's avatar
      Relax the block count check on deallocation in env_test · 746cfaac
      Lukáš Lalinský authored
      It seems that on some FS we get more blocks than we ask for. This is
      already handled when checking the allocated number of blocks, but
      after the file is closed it checks for an exact number of blocks,
      which fails on my machine.
      
      I changed the test to add one full page to the size, then calculate
      the expected number of blocks and check if the actual number of blocks
      is less or equal to that.
      746cfaac
    • sdong's avatar
      Add a unit test for behavior when merge operator and compaction filter co-exist. · f822129b
      sdong authored
      Summary: Add a unit test in db_test to verify the behavior when both of merge operator and compaction filter apply to a key when merging.
      
      Test Plan: Run the new test
      
      Reviewers: ljin, yhchiang, rven, igor
      
      Reviewed By: igor
      
      Subscribers: dhruba, leveldb
      
      Differential Revision: https://reviews.facebook.net/D28455
      f822129b
    • Yueh-Hsuan Chiang's avatar
      Fix SIGSEGV · 4161de92
      Yueh-Hsuan Chiang authored
      Summary: As a short-term fix, let's go back to previous way of calculating NeedsCompaction(). SIGSEGV happens because NeedsCompaction() can happen before super_version (and thus MutableCFOptions) is initialized.
      
      Test Plan: make check
      
      Reviewers: ljin, sdong, rven, yhchiang
      
      Reviewed By: yhchiang
      
      Subscribers: dhruba, leveldb
      
      Differential Revision: https://reviews.facebook.net/D28875
      4161de92
    • Hasnain Lakhani's avatar
      Fix broken test in 31b02d. · 373c665e
      Hasnain Lakhani authored
      Summary:
      CorruptionTest for backupable_db_test did not call
      GarbageCollect() after deleting a corrupt backup,
      which sometimes lead to test failures as the newly created backup
      would reuse the same backup ID and files and fail the consistency
      check.
      
      Moved around some of the test logic to ensure that GarbageCollect()
      is called at the right time.
      
      Test Plan:
      Run backupable_db_test eight times and make sure
      it passes repeatedly. Also run make check to make sure other
      tests don't fail.
      
      Reviewers: igor
      
      Reviewed By: igor
      
      Subscribers: dhruba, leveldb
      
      Differential Revision: https://reviews.facebook.net/D28863
      373c665e
    • Igor Canadi's avatar
      No CompactFiles in ROCKSDB_LITE · 772bc97f
      Igor Canadi authored
      Summary: It adds lots of code.
      
      Test Plan: compile for iOS, compile for mac. works.
      
      Reviewers: rven, sdong, ljin, yhchiang
      
      Reviewed By: yhchiang
      
      Subscribers: dhruba, leveldb
      
      Differential Revision: https://reviews.facebook.net/D28857
      772bc97f
    • Yueh-Hsuan Chiang's avatar
      Move NeedsCompaction() from VersionStorageInfo to CompactionPicker · 1d1a64f5
      Yueh-Hsuan Chiang authored
      Summary:
      Move NeedsCompaction() from VersionStorageInfo to CompactionPicker
      to allow different compaction strategy to have their own way to
      determine whether doing compaction is necessary.
      
      When compaction style is set to kCompactionStyleNone, then
      NeedsCompaction() will always return false.
      
      Test Plan:
      export ROCKSDB_TESTS=Compact
      ./db_test
      
      Reviewers: ljin, sdong, igor
      
      Reviewed By: igor
      
      Subscribers: dhruba, leveldb
      
      Differential Revision: https://reviews.facebook.net/D28719
      1d1a64f5
    • Igor Canadi's avatar
      Add concurrency to compacting SpatialDB · cd098015
      Igor Canadi authored
      Summary: This will speed up our import times
      
      Test Plan: Added simple unit test just to get code coverage
      
      Reviewers: sdong, ljin, yhchiang, rven, mohaps
      
      Reviewed By: mohaps
      
      Subscribers: dhruba, leveldb
      
      Differential Revision: https://reviews.facebook.net/D28869
      cd098015
    • Igor Canadi's avatar
      Fix include · 3c92e523
      Igor Canadi authored
      3c92e523
    • Igor Canadi's avatar
      Fix iOS compile with -Wshorten-64-to-32 · 25f27302
      Igor Canadi authored
      Summary: So iOS size_t is 32-bit, so we need to static_cast<size_t> any uint64_t :(
      
      Test Plan: TARGET_OS=IOS make static_lib
      
      Reviewers: dhruba, ljin, yhchiang, rven, sdong
      
      Reviewed By: sdong
      
      Subscribers: dhruba, leveldb
      
      Differential Revision: https://reviews.facebook.net/D28743
      25f27302
    • sdong's avatar
      Fix bug of reading from empty DB. · fa50abb7
      sdong authored
      Summary: I found that db_stress sometimes segfault on my machine. Fix the bug.
      
      Test Plan: make all check. Run db_stress
      
      Reviewers: ljin, yhchiang, rven, igor
      
      Reviewed By: igor
      
      Subscribers: leveldb, dhruba
      
      Differential Revision: https://reviews.facebook.net/D28803
      fa50abb7
    • Hasnain Lakhani's avatar
      Improve Backup Engine. · 31b02dc2
      Hasnain Lakhani authored
      Summary:
      Improve the backup engine by not deleting the corrupted
      backup when it is detected; instead leaving it to the client
      to delete the corrupted backup.
      
      Also add a BackupEngine::Open() call.
      
      Test Plan:
      Add check to CorruptionTest inside backupable_db_test
      to check that the corrupt backups are not deleted. The previous
      version of the code failed this test as backups were deleted,
      but after the changes in this commit, this test passes.
      
      Run make check to ensure that no other tests fail.
      
      Reviewers: sdong, benj, sanketh, sumeet, igor
      
      Reviewed By: igor
      
      Subscribers: dhruba, leveldb
      
      Differential Revision: https://reviews.facebook.net/D28521
      31b02dc2
  3. 13 Nov, 2014 9 commits
  4. 12 Nov, 2014 4 commits
  5. 11 Nov, 2014 10 commits