1. 05 May, 2020 2 commits
    • Yanqin Jin's avatar
      Fix db_stress when GetLiveFiles() flushes dropped CF (#6805) · 5a61e786
      Yanqin Jin authored
      Current impl. of db_stress will abort verification and report failure if
      GetLiveFiles() causes a dropped column family to be flushed. This is not
      To fix, this PR makes the following change:
      In GetLiveFiles, if flush is triggered and returns
      Status::IsColumnFamilyDropped(), then set status to Status::OK().
      This is OK because dropped column families will be skipped during the rest of
      this function, and valid column families will have their live files returned to
      Test plan (dev server):
      make check
      ./db_stress -ops_per_thread=1000 -get_live_files_one_in=100 -clear_column_family_one_in=100
      ./db_stress -disable_wal=1 -reopen=0 -ops_per_thread=1000 -get_live_files_one_in=100 -clear_column_family_one_in=100
      Pull Request resolved: https://github.com/facebook/rocksdb/pull/6805
      Reviewed By: ltamasi
      Differential Revision: D21390044
      Pulled By: riversand963
      fbshipit-source-id: de67846b95a4f1b88aa0a30c3d70c43cc68625b9
    • Levi Tamasi's avatar
      Expose the set of live blob files from Version/VersionSet (#6785) · a00ddf15
      Levi Tamasi authored
      The patch adds logic that returns the set of live blob files from
      `Version::AddLiveFiles` and `VersionSet::AddLiveFiles` (in addition to
      live table files), and also cleans up the code a bit, for example, by
      exposing only the numbers of table files as opposed to the earlier
      `FileDescriptor`s that no clients used. Moreover, the patch extends
      the `GetLiveFiles` API so that it also exposes blob files in the current version.
      Similarly to https://github.com/facebook/rocksdb/pull/6755,
      this is a building block for identifying and purging obsolete blob files.
      Pull Request resolved: https://github.com/facebook/rocksdb/pull/6785
      Test Plan: `make check`
      Reviewed By: riversand963
      Differential Revision: D21336210
      Pulled By: ltamasi
      fbshipit-source-id: fc1aede8a49eacd03caafbc5f6f9ce43b6270821
  2. 21 Feb, 2020 1 commit
    • sdong's avatar
      Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433) · fdf882de
      sdong authored
      When dynamically linking two binaries together, different builds of RocksDB from two sources might cause errors. To provide a tool for user to solve the problem, the RocksDB namespace is changed to a flag which can be overridden in build time.
      Pull Request resolved: https://github.com/facebook/rocksdb/pull/6433
      Test Plan: Build release, all and jtest. Try to build with ROCKSDB_NAMESPACE with another flag.
      Differential Revision: D19977691
      fbshipit-source-id: aa7f2d0972e1c31d75339ac48478f34f6cfcfb3e
  3. 13 Dec, 2019 1 commit
  4. 21 Sep, 2019 1 commit
  5. 05 Sep, 2019 1 commit
    • Affan Dar's avatar
      Adding DB::GetCurrentWalFile() API as a repliction/backup helper (#5765) · 229e6fbe
      Affan Dar authored
      Adding a light weight API to get last live WAL file name and size. Meant to be used as a helper for backup/restore tooling in a larger ecosystem such as MySQL with a MyRocks storage engine.
      Specifically within MySQL's backup/restore mechanism, this call can be made with a write lock on the mysql db to get a transactionally consistent snapshot of the current WAL file position along with other non-rocksdb log/data files.
      Without this, the alternative would be to take the aforementioned lock, scan the WAL dir for all files, find the last file and note its exact size as the rocksdb 'checkpoint'.
      Pull Request resolved: https://github.com/facebook/rocksdb/pull/5765
      Differential Revision: D17172717
      Pulled By: affandar
      fbshipit-source-id: f2fabafd4c0e6fc45f126670c8c88a9f84cb8a37
  6. 14 Jun, 2019 1 commit
    • Levi Tamasi's avatar
      Add missing check before calling PurgeObsoleteFiles in EnableFileDeletions (#5448) · a3b8c76d
      Levi Tamasi authored
      Calling PurgeObsoleteFiles with a JobContext for which HaveSomethingToDelete
      is false is a precondition violation. This would trigger an assertion in debug builds;
      however, in release builds with assertions disabled, this can result in the
      pending_purge_obsolete_files_ counter in DBImpl underflowing, which in turn can lead
      to the process hanging during database close.
      Pull Request resolved: https://github.com/facebook/rocksdb/pull/5448
      Differential Revision: D15792569
      Pulled By: ltamasi
      fbshipit-source-id: 82d92c9b4f6a9efcdc69dbb3d5a52a1ae2dd2472
  7. 07 Jun, 2019 1 commit
  8. 01 Jun, 2019 1 commit
  9. 31 May, 2019 2 commits
  10. 30 May, 2019 1 commit
  11. 13 Nov, 2018 1 commit
    • Yanqin Jin's avatar
      Remove redundant member var and set options (#4631) · 05dec0c7
      Yanqin Jin authored
      In the past, both `DBImpl::atomic_flush_` and
      `DBImpl::immutable_db_options_.atomic_flush` exist. However, we fail to set
      `immutable_db_options_.atomic_flush`, but use `DBImpl::atomic_flush_` which is
      set correctly. This does not lead to incorrect behavior, but is a duplicate of
      Since `immutable_db_options_` is always there and has `atomic_flush`, we should
      use it as source of truth and remove `DBImpl::atomic_flush_`.
      Pull Request resolved: https://github.com/facebook/rocksdb/pull/4631
      Differential Revision: D12928371
      Pulled By: riversand963
      fbshipit-source-id: f85a811959d3828aad4a3a1b05f71facf19c636d
  12. 31 Oct, 2018 1 commit
  13. 27 Oct, 2018 1 commit
  14. 10 Oct, 2018 1 commit
  15. 22 Mar, 2018 1 commit
  16. 10 Feb, 2018 1 commit
  17. 18 Jan, 2018 1 commit
    • Andrew Kryczka's avatar
      fix live WALs purged while file deletions disabled · 46e599fc
      Andrew Kryczka authored
      When calling `DisableFileDeletions` followed by `GetSortedWalFiles`, we guarantee the files returned by the latter call won't be deleted until after file deletions are re-enabled. However, `GetSortedWalFiles` didn't omit files already planned for deletion via `PurgeObsoleteFiles`, so the guarantee could be broken.
      We fix it by making `GetSortedWalFiles` wait for the number of pending purges to hit zero if file deletions are disabled. This condition is eventually met since `PurgeObsoleteFiles` is guaranteed to be called for the existing pending purges, and new purges cannot be scheduled while file deletions are disabled. Once the condition is met, `GetSortedWalFiles` simply returns the content of DB and archive directories, which nobody can delete (except for deletion scheduler, for which I plan to fix this bug later) until deletions are re-enabled.
      Closes https://github.com/facebook/rocksdb/pull/3341
      Differential Revision: D6681131
      Pulled By: ajkr
      fbshipit-source-id: 90b1e2f2362ea9ef715623841c0826611a817634
  18. 19 Jul, 2017 1 commit
  19. 16 Jul, 2017 1 commit
  20. 28 Apr, 2017 1 commit
  21. 04 Apr, 2017 1 commit
  22. 16 Mar, 2017 1 commit
    • Islam AbdelRahman's avatar
      Add macros to include file name and line number during Logging · e1916368
      Islam AbdelRahman authored
      current logging
      2017/03/14-14:20:30.393432 7fedde9f5700 (Original Log Time 2017/03/14-14:20:30.393414) [default] Level summary: base level 1 max bytes base 268435456 files[1 0 0 0 0 0 0] max score 0.25
      2017/03/14-14:20:30.393438 7fedde9f5700 [JOB 2] Try to delete WAL files size 61417909, prev total WAL file size 73820858, number of live WAL files 2.
      2017/03/14-14:20:30.393464 7fedde9f5700 [DEBUG] [JOB 2] Delete /dev/shm/old_logging//MANIFEST-000001 type=3 #1 -- OK
      2017/03/14-14:20:30.393472 7fedde9f5700 [DEBUG] [JOB 2] Delete /dev/shm/old_logging//000003.log type=0 #3 -- OK
      2017/03/14-14:20:31.427103 7fedd49f1700 [default] New memtable created with log file: #9. Immutable memtables: 0.
      2017/03/14-14:20:31.427179 7fedde9f5700 [JOB 3] Syncing log #6
      2017/03/14-14:20:31.427190 7fedde9f5700 (Original Log Time 2017/03/14-14:20:31.427170) Calling FlushMemTableToOutputFile with column family [default], flush slots available 1, compaction slots allowed 1, compaction slots scheduled 1
      Closes https://github.com/facebook/rocksdb/pull/1990
      Differential Revision: D4708695
      Pulled By: IslamAbdelRahman
      fbshipit-source-id: cb8968f
  23. 10 Dec, 2016 1 commit
  24. 24 Sep, 2016 1 commit
    • Yi Wu's avatar
      Split DBOptions into ImmutableDBOptions and MutableDBOptions · 9ed928e7
      Yi Wu authored
      Summary: Use ImmutableDBOptions/MutableDBOptions internally and DBOptions only for user-facing APIs. MutableDBOptions is barely a placeholder for now. I'll start to move options to MutableDBOptions in following diffs.
      Test Plan:
        make all check
      Reviewers: yhchiang, IslamAbdelRahman, sdong
      Reviewed By: sdong
      Subscribers: andrewkr, dhruba, leveldb
      Differential Revision: https://reviews.facebook.net/D64065
  25. 10 Jun, 2016 1 commit
    • Wanning Jiang's avatar
      Backup Options · 56887f6c
      Wanning Jiang authored
      Summary: Backup options file to private directory
      Test Plan:
      backupable_db_test.cc, BackupOptions
      	   Modify DB options by calling OpenDB for 3 times. Check the latest options file is in the right place. Also check no redundent files are backuped.
      Reviewers: andrewkr
      Reviewed By: andrewkr
      Subscribers: leveldb, dhruba, andrewkr
      Differential Revision: https://reviews.facebook.net/D59373
  26. 10 Feb, 2016 1 commit
  27. 20 Jun, 2015 1 commit
    • Venkatesh Radhakrishnan's avatar
      Add wal files to Checkpoint for multiple column families. · 04251e1e
      Venkatesh Radhakrishnan authored
      When there are multiple column families, the flush in
      GetLiveFiles is not atomic, so that there are entries in the wal files
      which are needed to get a consisten RocksDB. We now add the log files to
      the checkpoint.
      Test Plan:
      CheckpointCF - This test forces more data to be written to
      the other column families after the flush of the first column family but
      before the second.
      Reviewers: igor, yhchiang, IslamAbdelRahman, anthony, kradhakrishnan, sdong
      Reviewed By: sdong
      Subscribers: dhruba, leveldb
      Differential Revision: https://reviews.facebook.net/D40323
  28. 20 Mar, 2015 1 commit
    • Igor Canadi's avatar
      Don't delete files when column family is dropped · b088c83e
      Igor Canadi authored
      To understand the bug read t5943287 and check out the new test in column_family_test (ReadDroppedColumnFamily), iter 0.
      RocksDB contract allowes you to read a drop column family as long as there is a live reference. However, since our iteration ignores dropped column families, AddLiveFiles() didn't mark files of a dropped column families as live. So we deleted them.
      In this patch I no longer ignore dropped column families in the iteration. I think this behavior was confusing and it also led to this bug. Now if an iterator client wants to ignore dropped column families, he needs to do it explicitly.
      Test Plan: Added a new unit test that is failing on master. Unit test succeeds now.
      Reviewers: sdong, rven, yhchiang
      Reviewed By: yhchiang
      Subscribers: dhruba, leveldb
      Differential Revision: https://reviews.facebook.net/D32535
  29. 13 Feb, 2015 1 commit
    • Igor Canadi's avatar
      Introduce job_id for flush and compaction · e7ea51a8
      Igor Canadi authored
      It would be good to assing background job their IDs. Two benefits:
      1) makes LOGs more readable
      2) I might use it in my EventLogger, which will try to make our LOG easier to read/query/visualize
      Test Plan: ran rocksdb, read the LOG
      Reviewers: sdong, rven, yhchiang
      Reviewed By: yhchiang
      Subscribers: dhruba, leveldb
      Differential Revision: https://reviews.facebook.net/D31617
  30. 05 Feb, 2015 1 commit
    • Yueh-Hsuan Chiang's avatar
      Add a counter for collecting the wait time on db mutex. · 181191a1
      Yueh-Hsuan Chiang authored
      Add a counter for collecting the wait time on db mutex.
      Also add MutexWrapper and CondVarWrapper for measuring wait time.
      Test Plan:
      export ROCKSDB_TESTS=MutexWaitStats
      verify stats output using db_bench
      make clean
      make release
      ./db_bench --statistics=1 --benchmarks=fillseq,readwhilewriting --num=10000 --threads=10
      Sample output:
          rocksdb.db.mutex.wait.micros COUNT : 7546866
      Reviewers: MarkCallaghan, rven, sdong, igor
      Reviewed By: igor
      Subscribers: dhruba, leveldb
      Differential Revision: https://reviews.facebook.net/D32787
  31. 21 Nov, 2014 1 commit
  32. 15 Nov, 2014 3 commits
  33. 05 Nov, 2014 1 commit
  34. 30 Oct, 2014 2 commits
    • Igor Canadi's avatar
      WalManager · 63590548
      Igor Canadi authored
      Summary: Decoupling code that deals with archived log files outside of DBImpl. That will make this code easier to reason about and test. It will also make the code easier to improve, because an improver doesn't have to understand DBImpl code in entirety.
      Test Plan: added test
      Reviewers: ljin, yhchiang, rven, sdong
      Reviewed By: sdong
      Subscribers: dhruba, leveldb
      Differential Revision: https://reviews.facebook.net/D27873
    • Yueh-Hsuan Chiang's avatar
      Apply InfoLogLevel to the logs in db/db_filesnapshot.cc · 7b3a618f
      Yueh-Hsuan Chiang authored
      Summary: Apply InfoLogLevel to the logs in db/db_filesnapshot.cc
      Test Plan: make
      Reviewers: ljin, sdong, rven, igor
      Reviewed By: igor
      Subscribers: dhruba, leveldb
      Differential Revision: https://reviews.facebook.net/D27813
  35. 29 Oct, 2014 1 commit
    • Igor Canadi's avatar
      FlushProcess · a39e931e
      Igor Canadi authored
      Abstract out FlushProcess and take it out of DBImpl.
      This also includes taking DeletionState outside of DBImpl.
      Currently this diff is only doing the refactoring. Future work includes:
      1. Decoupling flush_process.cc, make it depend on less state
      2. Write flush_process_test, which will mock out everything that FlushProcess depends on and test it in isolation
      Test Plan: make check
      Reviewers: rven, yhchiang, sdong, ljin
      Reviewed By: ljin
      Subscribers: dhruba, leveldb
      Differential Revision: https://reviews.facebook.net/D27561