1. 30 May, 2019 1 commit
  2. 29 May, 2019 4 commits
    • Maysam Yabandeh's avatar
      WritePrepared: skip_concurrency_control option (#5330) · eab4f49a
      Maysam Yabandeh authored
      Summary:
      This enables the user to set TransactionDBOptions::skip_concurrency_control so the standard `DB::Write(const WriteOptions& opts, WriteBatch* updates)` would skip the concurrency control. This would give higher throughput to the users who know their use case doesn't need concurrency control.
      Pull Request resolved: https://github.com/facebook/rocksdb/pull/5330
      
      Differential Revision: D15525932
      
      Pulled By: maysamyabandeh
      
      fbshipit-source-id: 68421ac1ba34f549a4a8de9ce4c2dccf6fb4b06b
      eab4f49a
    • Maysam Yabandeh's avatar
      WritePrepared: disableWAL in commit without prepare (#5327) · f5576c33
      Maysam Yabandeh authored
      Summary:
      When committing a transaction without prepare, WritePrepared simply writes the batch to db and add the commit entry to CommitCache. When two_write_queues=true, following the rule of committing only from 2nd write queue, the first write, writes the batch and the only thing the 2nd write does is to write the commit entry to CommitCache. Currently the write batch in 2nd write is set to an empty LogData entry, while the write to the WAL could simply be entirely disabled.
      Pull Request resolved: https://github.com/facebook/rocksdb/pull/5327
      
      Differential Revision: D15424546
      
      Pulled By: maysamyabandeh
      
      fbshipit-source-id: 3d9ea3922d5196984c584d62a3ed57e1f7ca7b9f
      f5576c33
    • Siying Dong's avatar
      Add comments in compaction_picker.h · 4d0c3b1f
      Siying Dong authored
      Summary: Pull Request resolved: https://github.com/facebook/rocksdb/pull/5357
      
      Differential Revision: D15522825
      
      Pulled By: siying
      
      fbshipit-source-id: d775386b9d10c7179f5d3af2c821ed213abfacdf
      4d0c3b1f
    • Yanqin Jin's avatar
      Fix a clang analyze error (#5365) · b5e4ee2e
      Yanqin Jin authored
      Summary:
      The analyzer thinks max_allowed_ space can be 0. In that case, free_space will
      be assigned as free_space. It fails to realize that the function call
      GetFreeSpace actually sets the free_space variable properly, which is possibly
      due to lack of inter-function call analysis.
      Pull Request resolved: https://github.com/facebook/rocksdb/pull/5365
      
      Differential Revision: D15521790
      
      Pulled By: riversand963
      
      fbshipit-source-id: 839d0a285a1c8773a28a385f0c3be4bb7fbe32cb
      b5e4ee2e
  3. 25 May, 2019 15 commits
  4. 24 May, 2019 8 commits
  5. 23 May, 2019 2 commits
  6. 22 May, 2019 2 commits
  7. 21 May, 2019 2 commits
  8. 20 May, 2019 1 commit
    • Maysam Yabandeh's avatar
      WritePrepared: Clarify the need for two_write_queues in unordered_write (#5313) · 5c0e3041
      Maysam Yabandeh authored
      Summary:
      WritePrepared transactions when configured with two_write_queues=true offers higher throughput with unordered_write feature without however compromising the rocksdb guarantees. This is because it performs ordering among writes in a 2nd step that is not tied to memtable write speed. The 2nd step is naturally provided by 2PC when the commit phase does the ordering as well. Without 2PC, the 2nd step would only be provided when we use two_write_queues=true, where WritePrepared after performing the writes, in a 2nd step uses the 2nd queue to assign order to the writes.
      The patch clarifies the need for two_write_queues=true in the HISTORY and inline comments of unordered_writes. Moreover it extends the stress tests of WritePrepared to unordred_write.
      Pull Request resolved: https://github.com/facebook/rocksdb/pull/5313
      
      Differential Revision: D15379977
      
      Pulled By: maysamyabandeh
      
      fbshipit-source-id: 5b6f05b9b59285dcbf3b0532215ba9fe7d926e00
      5c0e3041
  9. 18 May, 2019 2 commits
    • Yanqin Jin's avatar
      Log replay integration for secondary instance (#5305) · fb4c6a31
      Yanqin Jin authored
      Summary:
      RocksDB secondary can replay both MANIFEST and WAL now.
      On the one hand, the memory usage by memtables will grow after replaying WAL for sometime. On the other hand, replaying the MANIFEST can bring the database persistent data to a more recent point in time, giving us the opportunity to discard some memtables containing out-dated data.
      This PR coordinates the MANIFEST and WAL replay, using the updates from MANIFEST replay to update the active memtable and immutable memtable list of each column family.
      Pull Request resolved: https://github.com/facebook/rocksdb/pull/5305
      
      Differential Revision: D15386512
      
      Pulled By: riversand963
      
      fbshipit-source-id: a3ea6fc415f8382d8cf624f52a71ebdcffa3e355
      fb4c6a31
    • yiwu-arbug's avatar
      Reduce iterator key comparison for upper/lower bound check (#5111) · f3a78475
      yiwu-arbug authored
      Summary:
      Previously if iterator upper/lower bound presents, `DBIter` will check the bound for every key. This patch turns the check into per-file or per-data block check when applicable, by checking against either file largest/smallest key or block index key.
      Pull Request resolved: https://github.com/facebook/rocksdb/pull/5111
      
      Differential Revision: D15330061
      
      Pulled By: siying
      
      fbshipit-source-id: 8a653fe3cd50d94d81eb2d13b087326c58ee2024
      f3a78475
  10. 17 May, 2019 3 commits