Skip to content
GitLab
  1. 31 Aug, 2017 1 commit
  3. 19 Aug, 2017 2 commits
  5. 16 Jul, 2017 1 commit
  7. 12 Jul, 2017 1 commit
  9. 06 Jun, 2017 1 commit
  11. 18 May, 2017 1 commit
  13. 13 Apr, 2017 1 commit
  15. 10 Mar, 2017 1 commit
  17. 11 Feb, 2017 1 commit
  19. 18 Nov, 2016 1 commit
  21. 19 Oct, 2016 1 commit
  23. 11 Aug, 2016 1 commit
    • sdong's avatar
      Increase RocksDB version · 5370f44a
      sdong authored 
      Summary: RocksDB 4.11 has been branched out. Now need to move to 4.12.

Test Plan: N/A

Reviewers: kradhakrishnan, andrewkr, IslamAbdelRahman

Reviewed By: IslamAbdelRahman

Subscribers: leveldb, andrewkr, dhruba

Differential Revision: https://reviews.facebook.net/D61845
      5370f44a
  25. 22 Jul, 2016 1 commit
  27. 10 Jun, 2016 1 commit
  29. 03 May, 2016 1 commit
  31. 14 Apr, 2016 1 commit
  33. 02 Mar, 2016 1 commit
    • sdong's avatar
      Update current version to 4.6 · 4572a2d8
      sdong authored 
      Summary: 4.5 is already cut, we can now increase the version in 4.6.

Test Plan: Not needed.

Reviewers: anthony, kradhakrishnan, andrewkr, yhchiang, IslamAbdelRahman

Reviewed By: IslamAbdelRahman

Subscribers: leveldb, dhruba

Differential Revision: https://reviews.facebook.net/D54963
      4572a2d8
  35. 10 Feb, 2016 1 commit
  37. 06 Feb, 2016 1 commit
    • sdong's avatar
      Update version to 4.5 · 73a9b0f4
      sdong authored 
      Summary: Time to cut branch for release 4.5. Change the versions.

Test Plan: Not needed

Reviewers: IslamAbdelRahman, yhchiang, kradhakrishnan, andrewkr, anthony

Reviewed By: anthony

Subscribers: leveldb, dhruba

Differential Revision: https://reviews.facebook.net/D53883
      73a9b0f4
  39. 17 Dec, 2015 1 commit
  41. 17 Nov, 2015 1 commit
  43. 20 Oct, 2015 1 commit
    • Islam AbdelRahman's avatar
      Bump version to 4.2 · e3b1d23d
      Islam AbdelRahman authored 
      Summary: Bump the version to 4.2 ( the unreleased version ), so that when fbcode_unittests run it can differentiate between old and new APIs

Test Plan: make check

Reviewers: sdong, yhchiang, igor

Reviewed By: igor

Subscribers: dhruba

Differential Revision: https://reviews.facebook.net/D49041
      e3b1d23d
  45. 09 Oct, 2015 1 commit
  47. 10 Sep, 2015 1 commit
  49. 14 Aug, 2015 1 commit
  51. 16 Jul, 2015 1 commit
    • Igor Canadi's avatar
      Bump to RocksDB 3.13 · 12c5528a
      Igor Canadi authored 
      Summary: master is now 3.13-to-be. I'm testing some internal stuff that has #ifdef based on RocksDB version.

Test Plan: none

Reviewers: sdong, anthony

Reviewed By: anthony

Subscribers: dhruba, leveldb

Differential Revision: https://reviews.facebook.net/D42249
      12c5528a
  53. 03 Jul, 2015 1 commit
  55. 08 May, 2015 1 commit
  57. 15 Jan, 2015 1 commit
    • Igor Canadi's avatar
      New BlockBasedTable version -- better compressed block format · 9ab5adfc
      Igor Canadi authored 
      Summary:
This diff adds BlockBasedTable format_version = 2. New format version brings better compressed block format for these compressions:
1) Zlib -- encode decompressed size in compressed block header
2) BZip2 -- encode decompressed size in compressed block header
3) LZ4 and LZ4HC -- instead of doing memcpy of size_t encode size as varint32. memcpy is very bad because the DB is not portable accross big/little endian machines or even platforms where size_t might be 8 or 4 bytes.

It does not affect format for snappy.

If you write a new database with format_version = 2, it will not be readable by RocksDB versions before 3.10. DB::Open() will return corruption in that case.

Test Plan:
Added a new test in db_test.
I will also run db_bench and verify VSIZE when block_cache == 1GB

Reviewers: yhchiang, rven, MarkCallaghan, dhruba, sdong

Reviewed By: sdong

Subscribers: dhruba, leveldb

Differential Revision: https://reviews.facebook.net/D31461
      9ab5adfc
  59. 06 Dec, 2014 1 commit
  61. 11 Nov, 2014 1 commit
  63. 05 Nov, 2014 1 commit
  65. 03 Oct, 2014 1 commit
    • Igor Canadi's avatar
      Don't keep managing two rocksdb version · 0908ddce
      Igor Canadi authored 
      Summary:
Before this diff, there are two places with rocksdb versions. After the diff:
1. we only have one source of truth for rocksdb version
2. we have a script that we can use to get the version that we can use in other compilations (java, go, etc).

Test Plan: make

Reviewers: yhchiang, sdong, ljin

Reviewed By: ljin

Subscribers: leveldb

Differential Revision: https://reviews.facebook.net/D24333
      0908ddce
  67. 19 Aug, 2014 1 commit
  69. 23 Jul, 2014 1 commit
  71. 11 Jul, 2014 1 commit
  73. 24 May, 2014 1 commit
  75. 14 May, 2014 1 commit
    • Igor Canadi's avatar
      TablePropertiesCollectorFactory · 26f5dd9a
      Igor Canadi authored 
      Summary:
This diff addresses task #4296714 and rethinks how users provide us with TablePropertiesCollectors as part of Options.

Here's description of task #4296714:
       I'm debugging #4295529 and noticed that our count of user properties kDeletedKeys is wrong. We're sharing one single InternalKeyPropertiesCollector with all Table Builders. In LOG Files, we're outputting number of kDeletedKeys as connected with a single table, while it's actually the total count of deleted keys since creation of the DB.

       For example, this table has 3155 entries and 1391828 deleted keys.

The problem with current approach that we call methods on a single TablePropertiesCollector for all the tables we create. Even worse, we could do it from multiple threads at the same time and TablePropertiesCollector has no way of knowing which table we're calling it for.

Good part: Looks like nobody inside Facebook is using Options::table_properties_collectors. This means we should be able to painfully change the API.

In this change, I introduce TablePropertiesCollectorFactory. For every table we create, we call `CreateTablePropertiesCollector`, which creates a TablePropertiesCollector for a single table. We then use it sequentially from a single thread, which means it doesn't have to be thread-safe.

Test Plan:
Added a test in table_properties_collector_test that fails on master (build two tables, assert that kDeletedKeys count is correct for the second one).
Also, all other tests

Reviewers: sdong, dhruba, haobo, kailiu

Reviewed By: kailiu

CC: leveldb

Differential Revision: https://reviews.facebook.net/D18579
      26f5dd9a
  77. 29 Apr, 2014 1 commit