Skip to content
  • Maysam Yabandeh's avatar
    Declare snapshot refresh incompatible with delete range (#5625) · d9dc6b46
    Maysam Yabandeh authored
    Summary:
    The ::snap_refresh_nanos option is incompatible with DeleteRange feature. Currently the code relies on range_del_agg.IsEmpty() to disable it if there are range delete tombstones. However ::IsEmpty does not guarantee that there is no RangeDelete tombstones in the SST files. The patch declares the two features incompatible in inline comments until we later figure how to properly detect the presence of RangeDelete tombstones in compaction inputs.
    Pull Request resolved: https://github.com/facebook/rocksdb/pull/5625
    
    Differential Revision: D16468218
    
    Pulled By: maysamyabandeh
    
    fbshipit-source-id: bd7beca278bc7e1db75e7ee4522d05a3a6ca86f4
    d9dc6b46