Skip to content
  • Adam Simpkins's avatar
    Fix many bugs in log statement arguments (#5089) · c06c4c01
    Adam Simpkins authored
    Summary:
    Annotate all of the logging functions to inform the compiler that these
    use printf-style formatting arguments.  This allows the compiler to emit
    warnings if the format arguments are incorrect.
    
    This also fixes many problems reported now that format string checking
    is enabled.  Many of these are simply mix-ups in the argument type (e.g,
    int vs uint64_t), but in several cases the wrong number of arguments
    were being passed in which can cause the code to crash.
    
    The primary motivation for this was to fix the log message in
    `DBImpl::SwitchMemtable()` which caused a segfault due to an extra %s
    format parameter with no argument supplied.
    Pull Request resolved: https://github.com/facebook/rocksdb/pull/5089
    
    Differential Revision: D14574795
    
    Pulled By: simpkins
    
    fbshipit-source-id: 0921b03f0743652bf4ae21e414ff54b3bb65422a
    c06c4c01