Skip to content
  • Zhichao Cao's avatar
    Ingest SST files with checksum information (#6891) · b3585a11
    Zhichao Cao authored
    Summary:
    Application can ingest SST files with file checksum information, such that during ingestion, DB is able to check data integrity and identify of the SST file. The PR introduces generate_and_verify_file_checksum to IngestExternalFileOption to control if the ingested checksum information should be verified with the generated checksum.
    
        1. If generate_and_verify_file_checksum options is *FALSE*: *1)* if DB does not enable SST file checksum, the checksum information ingested will be ignored; *2)* if DB enables the SST file checksum and the checksum function name matches the checksum function name in DB, we trust the ingested checksum, store it in Manifest. If the checksum function name does not match, we treat that as an error and fail the IngestExternalFile() call.
        2. If generate_and_verify_file_checksum options is *TRUE*: *1)* if DB does not enable SST file checksum, the checksum information ingested will be ignored; *2)* if DB enable the SST file checksum, we will use the checksum generator from DB to calculate the checksum for each ingested SST files after they are copied or moved. Then, compare the checksum results with the ingested checksum information: _A)_ if the checksum function name does not match, _verification always report true_ and we store the DB generated checksum information in Manifest. _B)_ if the checksum function name mach, and checksum match, ingestion continues and stores the checksum information in the Manifest. Otherwise, terminate file ingestion and report file corruption.
    Pull Request resolved: https://github.com/facebook/rocksdb/pull/6891
    
    Test Plan: added unit test, pass make asan_check
    
    Reviewed By: pdillinger
    
    Differential Revision: D21935988
    
    Pulled By: zhichao-cao
    
    fbshipit-source-id: 7b55f486632db467e76d72602218d0658aa7f6ed
    b3585a11