Skip to content
  • Andrew Kryczka's avatar
    Fail BackupEngine::Open upon meta-file read error · 83f9a6fd
    Andrew Kryczka authored
    Summary:
    We used to treat any failure to read a backup's meta-file as if the backup were corrupted; however, we should distinguish corruption errors from errors in the backup Env. This fixes an issue where callers would get inconsistent results from GetBackupInfo() if they called it on an engine that encountered Env error during initialization. Now we fail Initialize() in this case so callers cannot invoke GetBackupInfo() on such engines.
    Closes https://github.com/facebook/rocksdb/pull/1654
    
    Differential Revision: D4318573
    
    Pulled By: ajkr
    
    fbshipit-source-id: f7a7c54
    83f9a6fd