• Igor Canadi's avatar
    Turn on -Wshorten-64-to-32 and fix all the errors · 767777c2
    Igor Canadi authored
    We need to turn on -Wshorten-64-to-32 for mobile. See D1671432 (internal phabricator) for details.
    This diff turns on the warning flag and fixes all the errors. There were also some interesting errors that I might call bugs, especially in plain table. Going forward, I think it makes sense to have this flag turned on and be very very careful when converting 64-bit to 32-bit variables.
    Test Plan: compiles
    Reviewers: ljin, rven, yhchiang, sdong
    Reviewed By: yhchiang
    Subscribers: bobbaldwin, dhruba, leveldb
    Differential Revision: https://reviews.facebook.net/D28689