Skip to content
  • Igor Canadi's avatar
    Deprecate WriteOptions::timeout_hint_us · 5aea98dd
    Igor Canadi authored
    Summary:
    In one of our recent meetings, we discussed deprecating features that are not being actively used. One of those features, at least within Facebook, is timeout_hint. The feature is really nicely implemented, but if nobody needs it, we should remove it from our code-base (until we get a valid use-case). Some arguments:
    * Less code == better icache hit rate, smaller builds, simpler code
    * The motivation for adding timeout_hint_us was to work-around RocksDB's stall issue. However, we're currently addressing the stall issue itself (see @sdong's recent work on stall write_rate), so we should never see sharp lock-ups in the future.
    * Nobody is using the feature within Facebook's code-base. Googling for `timeout_hint_us` also doesn't yield any users.
    
    Test Plan: make check
    
    Reviewers: anthony, kradhakrishnan, sdong, yhchiang
    
    Reviewed By: yhchiang
    
    Subscribers: sdong, dhruba, leveldb
    
    Differential Revision: https://reviews.facebook.net/D41937
    5aea98dd