Skip to content
  • Peter Dillinger's avatar
    Fix false NotFound from batched MultiGet with kHashSearch (#6821) · 4584a99a
    Peter Dillinger authored
    Summary:
    The error is assigning KeyContext::s to NotFound status in a
    table reader for a "not found in this table" case, which skips searching
    in later tables, like only a delete should. (The hash search index iterator
    is the only one that can return status NotFound even if Valid() == false.)
    
    This was detected by intermittent failure in
    MultiThreadedDBTest.MultiThreaded/5, a kHashSearch configuration.
    Pull Request resolved: https://github.com/facebook/rocksdb/pull/6821
    
    Test Plan: modified existing unit test to reproduce problem
    
    Reviewed By: anand1976
    
    Differential Revision: D21450469
    
    Pulled By: pdillinger
    
    fbshipit-source-id: 7478003684d637dbd491cdac81468041a791be2c
    4584a99a