Skip to content
  • Yanqin Jin's avatar
    Report corrupted keys during compaction (#7124) · 30bfa2a4
    Yanqin Jin authored
    Summary:
    Currently, RocksDB lets compaction to go through even in case of
    corrupted keys, the number of which is reported in CompactionJobStats.
    However, RocksDB does not check this value. We should let compaction run
    in a stricter mode.
    
    Temporarily disable two tests that allow corrupted keys in compaction.
    With this PR, the two tests will assert(false) and terminate. Still need
    to investigate what is the recommended google-test way of doing it.
    Death test (EXPECT_DEATH) in gtest has warnings now.
    
    Pull Request resolved: https://github.com/facebook/rocksdb/pull/7124
    
    Test Plan: make check
    
    Reviewed By: ajkr
    
    Differential Revision: D22530722
    
    Pulled By: riversand963
    
    fbshipit-source-id: 6a5a6a992028c6d4f92cb74693c92db462ae4ad6
    30bfa2a4