Skip to content
  • Yanqin Jin's avatar
    Remove unnecessary inclusion of version_edit.h in env (#6952) · 3020df9d
    Yanqin Jin authored
    Summary:
    In db_options.c, we should avoid including header files in the `db` directory to avoid introducing unnecessary dependency. The reason why `version_edit.h` has been included in `db_options.cc` is because we need two constants, `kUnknownChecksum` and `kUnknownChecksumFuncName`. We can put these two constants as `constexpr` in the public header `file_checksum.h`.
    
    Test plan (devserver):
    make check
    Pull Request resolved: https://github.com/facebook/rocksdb/pull/6952
    
    Reviewed By: zhichao-cao
    
    Differential Revision: D21925341
    
    Pulled By: riversand963
    
    fbshipit-source-id: 2902f3b74c97f0cf16c58ad24c095c787c3a40e2
    3020df9d