• Igor Canadi's avatar
    TablePropertiesCollectorFactory · 26f5dd9a
    Igor Canadi authored
    This diff addresses task #4296714 and rethinks how users provide us with TablePropertiesCollectors as part of Options.
    Here's description of task #4296714:
           I'm debugging #4295529 and noticed that our count of user properties kDeletedKeys is wrong. We're sharing one single InternalKeyPropertiesCollector with all Table Builders. In LOG Files, we're outputting number of kDeletedKeys as connected with a single table, while it's actually the total count of deleted keys since creation of the DB.
           For example, this table has 3155 entries and 1391828 deleted keys.
    The problem with current approach that we call methods on a single TablePropertiesCollector for all the tables we create. Even worse, we could do it from multiple threads at the same time and TablePropertiesCollector has no way of knowing which table we're calling it for.
    Good part: Looks like nobody inside Facebook is using Options::table_properties_collectors. This means we should be able to painfully change the API.
    In this change, I introduce TablePropertiesCollectorFactory. For every table we create, we call `CreateTablePropertiesCollector`, which creates a TablePropertiesCollector for a single table. We then use it sequentially from a single thread, which means it doesn't have to be thread-safe.
    Test Plan:
    Added a test in table_properties_collector_test that fails on master (build two tables, assert that kDeletedKeys count is correct for the second one).
    Also, all other tests
    Reviewers: sdong, dhruba, haobo, kailiu
    Reviewed By: kailiu
    CC: leveldb
    Differential Revision: https://reviews.facebook.net/D18579