Skip to content
  • Peter Dillinger's avatar
    Allow missing "unversioned" python, as in CentOS 8 (#6883) · 0c56fc4d
    Peter Dillinger authored
    Summary:
    RocksDB Makefile was assuming existence of 'python' command,
    which is not present in CentOS 8. We avoid using 'python' if 'python3' is available.
    
    Also added fancy logic to format-diff.sh to make clang-format-diff.py for Python2 work even with Python3 only (as some CentOS 8 FB machines come equipped)
    
    Also, now use just 'python3' for PYTHON if not found so that an informative
    "command not found" error will result rather than something weird.
    Pull Request resolved: https://github.com/facebook/rocksdb/pull/6883
    
    Test Plan: manually tried some variants, 'make check' on a fresh CentOS 8 machine without 'python' executable or Python2 but with clang-format-diff.py for Python2.
    
    Reviewed By: gg814
    
    Differential Revision: D21767029
    
    Pulled By: pdillinger
    
    fbshipit-source-id: 54761b376b140a3922407bdc462f3572f461d0e9
    0c56fc4d