From f5b63f4a8dd3e22ffc405a1a6119a961f8332578 Mon Sep 17 00:00:00 2001
From: Mike McQuaid <mike@mikemcquaid.com>
Date: Mon, 9 Jan 2017 12:31:00 +0000
Subject: [PATCH] Deprecate brew (un)linkapps.
Unfortunately `brew linkapps` cannot behave nicely with e.g. Spotlight
using either aliases or symlinks and Homebrew formulae do not build
"proper" `.app` bundles that can be relocated. Instead, please consider
using `brew cask` and migrate formulae using `.app`s to casks.
---
Library/Homebrew/cmd/linkapps.rb | 16 +++++++++++++++-
Library/Homebrew/cmd/unlinkapps.rb | 13 ++++++++++++-
docs/brew.1.html | 14 ++++++++++++--
manpages/brew.1 | 10 ++++++++--
4 files changed, 47 insertions(+), 6 deletions(-)
diff --git a/Library/Homebrew/cmd/linkapps.rb b/Library/Homebrew/cmd/linkapps.rb
index bd88409aaa..7dd1a6b939 100644
--- a/Library/Homebrew/cmd/linkapps.rb
+++ b/Library/Homebrew/cmd/linkapps.rb
@@ -1,6 +1,11 @@
#: * `linkapps` [`--local`] [<formulae>]:
#: Find installed formulae that provide `.app`-style macOS apps and symlink them
-#: into `/Applications`, allowing for easier access.
+#: into `/Applications`, allowing for easier access (deprecated).
+#:
+#: Unfortunately `brew linkapps` cannot behave nicely with e.g. Spotlight using
+#: either aliases or symlinks and Homebrew formulae do not build "proper" `.app`
+#: bundles that can be relocated. Instead, please consider using `brew cask` and
+#: migrate formulae using `.app`s to casks.
#:
#: If no <formulae> are provided, all of them will have their apps symlinked.
#:
@@ -14,6 +19,15 @@ module Homebrew
module_function
def linkapps
+ opoo <<-EOS.undent
+ `brew linkapps` has been deprecated and will eventually be removed!
+
+ Unfortunately `brew linkapps` cannot behave nicely with e.g. Spotlight using
+ either aliases or symlinks and Homebrew formulae do not build "proper" `.app`
+ bundles that can be relocated. Instead, please consider using `brew cask` and
+ migrate formulae using `.app`s to casks.
+ EOS
+
target_dir = linkapps_target(local: ARGV.include?("--local"))
unless target_dir.directory?
diff --git a/Library/Homebrew/cmd/unlinkapps.rb b/Library/Homebrew/cmd/unlinkapps.rb
index d04ef9ee40..b2ba458bf6 100644
--- a/Library/Homebrew/cmd/unlinkapps.rb
+++ b/Library/Homebrew/cmd/unlinkapps.rb
@@ -1,5 +1,10 @@
#: * `unlinkapps` [`--local`] [`--dry-run`] [<formulae>]:
-#: Remove symlinks created by `brew linkapps` from `/Applications`.
+#: Remove symlinks created by `brew linkapps` from `/Applications` (deprecated).
+#:
+#: Unfortunately `brew linkapps` cannot behave nicely with e.g. Spotlight using
+#: either aliases or symlinks and Homebrew formulae do not build "proper" `.app`
+#: bundles that can be relocated. Instead, please consider using `brew cask` and
+#: migrate formulae using `.app`s to casks.
#:
#: If no <formulae> are provided, all linked apps will be removed.
#:
@@ -15,6 +20,12 @@ module Homebrew
module_function
def unlinkapps
+ opoo <<-EOS.undent
+ `brew unlinkapps` has been deprecated and will eventually be removed!
+
+ Unfortunately `brew linkapps` cannot behave nicely with e.g. Spotlight using either aliases or symlinks and Homebrew formulae do not build "proper" `.app` bundles that can be relocated. Instead, please consider using `brew cask` and migrate formulae using `.app`s to casks.
+ EOS
+
target_dir = linkapps_target(local: ARGV.include?("--local"))
unlinkapps_from_dir(target_dir, dry_run: ARGV.dry_run?)
diff --git a/docs/brew.1.html b/docs/brew.1.html
index 8c81b1ddb0..ba65157cb9 100644
--- a/docs/brew.1.html
+++ b/docs/brew.1.html
@@ -223,7 +223,12 @@ actually link or delete any files.</p>
<p>If <code>--force</code> is passed, Homebrew will allow keg-only formulae to be linked.</p></dd>
<dt><code>linkapps</code> [<code>--local</code>] [<var>formulae</var>]</dt><dd><p>Find installed formulae that provide <code>.app</code>-style macOS apps and symlink them
-into <code>/Applications</code>, allowing for easier access.</p>
+into <code>/Applications</code>, allowing for easier access (deprecated).</p>
+
+<p>Unfortunately <code>brew linkapps</code> cannot behave nicely with e.g. Spotlight using
+either aliases or symlinks and Homebrew formulae do not build "proper" <code>.app</code>
+bundles that can be relocated. Instead, please consider using <code>brew cask</code> and
+migrate formulae using <code>.app</code>s to casks.</p>
<p>If no <var>formulae</var> are provided, all of them will have their apps symlinked.</p>
@@ -369,7 +374,12 @@ for temporarily disabling a formula:
<p>If <code>--dry-run</code> or <code>-n</code> is passed, Homebrew will list all files which would
be unlinked, but will not actually unlink or delete any files.</p></dd>
-<dt><code>unlinkapps</code> [<code>--local</code>] [<code>--dry-run</code>] [<var>formulae</var>]</dt><dd><p>Remove symlinks created by <code>brew linkapps</code> from <code>/Applications</code>.</p>
+<dt><code>unlinkapps</code> [<code>--local</code>] [<code>--dry-run</code>] [<var>formulae</var>]</dt><dd><p>Remove symlinks created by <code>brew linkapps</code> from <code>/Applications</code> (deprecated).</p>
+
+<p>Unfortunately <code>brew linkapps</code> cannot behave nicely with e.g. Spotlight using
+either aliases or symlinks and Homebrew formulae do not build "proper" <code>.app</code>
+bundles that can be relocated. Instead, please consider using <code>brew cask</code> and
+migrate formulae using <code>.app</code>s to casks.</p>
<p>If no <var>formulae</var> are provided, all linked apps will be removed.</p>
diff --git a/manpages/brew.1 b/manpages/brew.1
index c9269e7b39..aa1d1c1d00 100644
--- a/manpages/brew.1
+++ b/manpages/brew.1
@@ -294,7 +294,10 @@ If \fB\-\-force\fR is passed, Homebrew will allow keg\-only formulae to be linke
.
.TP
\fBlinkapps\fR [\fB\-\-local\fR] [\fIformulae\fR]
-Find installed formulae that provide \fB\.app\fR\-style macOS apps and symlink them into \fB/Applications\fR, allowing for easier access\.
+Find installed formulae that provide \fB\.app\fR\-style macOS apps and symlink them into \fB/Applications\fR, allowing for easier access (deprecated)\.
+.
+.IP
+Unfortunately \fBbrew linkapps\fR cannot behave nicely with e\.g\. Spotlight using either aliases or symlinks and Homebrew formulae do not build "proper" \fB\.app\fR bundles that can be relocated\. Instead, please consider using \fBbrew cask\fR and migrate formulae using \fB\.app\fRs to casks\.
.
.IP
If no \fIformulae\fR are provided, all of them will have their apps symlinked\.
@@ -508,7 +511,10 @@ If \fB\-\-dry\-run\fR or \fB\-n\fR is passed, Homebrew will list all files which
.
.TP
\fBunlinkapps\fR [\fB\-\-local\fR] [\fB\-\-dry\-run\fR] [\fIformulae\fR]
-Remove symlinks created by \fBbrew linkapps\fR from \fB/Applications\fR\.
+Remove symlinks created by \fBbrew linkapps\fR from \fB/Applications\fR (deprecated)\.
+.
+.IP
+Unfortunately \fBbrew linkapps\fR cannot behave nicely with e\.g\. Spotlight using either aliases or symlinks and Homebrew formulae do not build "proper" \fB\.app\fR bundles that can be relocated\. Instead, please consider using \fBbrew cask\fR and migrate formulae using \fB\.app\fRs to casks\.
.
.IP
If no \fIformulae\fR are provided, all linked apps will be removed\.
--
GitLab