From efbfb90c42b6c106ab71c7a5340e05b81e7a133b Mon Sep 17 00:00:00 2001
From: Waldir Pimenta <waldyrious@gmail.com>
Date: Thu, 13 Aug 2020 22:18:47 +0100
Subject: [PATCH] Use cask with name for basic info command test
Also add non-dummy URL in the test fixture, to match the name, version, etc.
---
Library/Homebrew/test/cask/cmd/home_spec.rb | 2 +-
Library/Homebrew/test/cask/cmd/info_spec.rb | 14 +++++++-------
Library/Homebrew/test/cask/cmd/list_spec.rb | 2 +-
.../fixtures/cask/Casks/local-transmission.rb | 2 +-
4 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/Library/Homebrew/test/cask/cmd/home_spec.rb b/Library/Homebrew/test/cask/cmd/home_spec.rb
index ca9e5481f0..bc3d507a5f 100644
--- a/Library/Homebrew/test/cask/cmd/home_spec.rb
+++ b/Library/Homebrew/test/cask/cmd/home_spec.rb
@@ -16,7 +16,7 @@ describe Cask::Cmd::Home, :cask do
it "works for multiple Casks" do
expect(described_class).to receive(:open_url).with("https://brew.sh/")
- expect(described_class).to receive(:open_url).with("https://brew.sh/")
+ expect(described_class).to receive(:open_url).with("https://transmissionbt.com/")
described_class.run("local-caffeine", "local-transmission")
end
diff --git a/Library/Homebrew/test/cask/cmd/info_spec.rb b/Library/Homebrew/test/cask/cmd/info_spec.rb
index ea3385dc52..44ca60e9bb 100644
--- a/Library/Homebrew/test/cask/cmd/info_spec.rb
+++ b/Library/Homebrew/test/cask/cmd/info_spec.rb
@@ -10,16 +10,16 @@ describe Cask::Cmd::Info, :cask do
it "displays some nice info about the specified Cask" do
expect {
- described_class.run("local-caffeine")
+ described_class.run("local-transmission")
}.to output(<<~EOS).to_stdout
- local-caffeine: 1.2.3
- https://brew.sh/
+ local-transmission: 2.61
+ https://transmissionbt.com/
Not installed
- From: https://github.com/Homebrew/homebrew-cask/blob/HEAD/Casks/local-caffeine.rb
+ From: https://github.com/Homebrew/homebrew-cask/blob/HEAD/Casks/local-transmission.rb
==> Name
- None
+ Transmission
==> Artifacts
- Caffeine.app (App)
+ Transmission.app (App)
EOS
end
@@ -51,7 +51,7 @@ describe Cask::Cmd::Info, :cask do
Caffeine.app (App)
local-transmission: 2.61
- https://brew.sh/
+ https://transmissionbt.com/
Not installed
From: https://github.com/Homebrew/homebrew-cask/blob/HEAD/Casks/local-transmission.rb
==> Name
diff --git a/Library/Homebrew/test/cask/cmd/list_spec.rb b/Library/Homebrew/test/cask/cmd/list_spec.rb
index b3af63e31f..6f65837b52 100644
--- a/Library/Homebrew/test/cask/cmd/list_spec.rb
+++ b/Library/Homebrew/test/cask/cmd/list_spec.rb
@@ -90,7 +90,7 @@ describe Cask::Cmd::List, :cask do
let(:casks) { ["local-caffeine", "local-transmission"] }
let(:expected_output) {
<<~EOS
- [{"token":"local-caffeine","name":[],"desc":null,"homepage":"https://brew.sh/","url":"file:///usr/local/Homebrew/Library/Homebrew/test/support/fixtures/cask/caffeine.zip","appcast":null,"version":"1.2.3","sha256":"67cdb8a02803ef37fdbf7e0be205863172e41a561ca446cd84f0d7ab35a99d94","artifacts":[["Caffeine.app"]],"caveats":null,"depends_on":{},"conflicts_with":null,"container":null,"auto_updates":null},{"token":"local-transmission","name":["Transmission"],"desc":null,"homepage":"https://brew.sh/","url":"file:///usr/local/Homebrew/Library/Homebrew/test/support/fixtures/cask/transmission-2.61.dmg","appcast":null,"version":"2.61","sha256":"e44ffa103fbf83f55c8d0b1bea309a43b2880798dae8620b1ee8da5e1095ec68","artifacts":[["Transmission.app"]],"caveats":null,"depends_on":{},"conflicts_with":null,"container":null,"auto_updates":null}]
+ [{"token":"local-caffeine","name":[],"desc":null,"homepage":"https://brew.sh/","url":"file:///usr/local/Homebrew/Library/Homebrew/test/support/fixtures/cask/caffeine.zip","appcast":null,"version":"1.2.3","sha256":"67cdb8a02803ef37fdbf7e0be205863172e41a561ca446cd84f0d7ab35a99d94","artifacts":[["Caffeine.app"]],"caveats":null,"depends_on":{},"conflicts_with":null,"container":null,"auto_updates":null},{"token":"local-transmission","name":["Transmission"],"desc":null,"homepage":"https://transmissionbt.com/","url":"file:///usr/local/Homebrew/Library/Homebrew/test/support/fixtures/cask/transmission-2.61.dmg","appcast":null,"version":"2.61","sha256":"e44ffa103fbf83f55c8d0b1bea309a43b2880798dae8620b1ee8da5e1095ec68","artifacts":[["Transmission.app"]],"caveats":null,"depends_on":{},"conflicts_with":null,"container":null,"auto_updates":null}]
EOS
}
diff --git a/Library/Homebrew/test/support/fixtures/cask/Casks/local-transmission.rb b/Library/Homebrew/test/support/fixtures/cask/Casks/local-transmission.rb
index eada3e74c0..e765f67764 100644
--- a/Library/Homebrew/test/support/fixtures/cask/Casks/local-transmission.rb
+++ b/Library/Homebrew/test/support/fixtures/cask/Casks/local-transmission.rb
@@ -4,7 +4,7 @@ cask "local-transmission" do
url "file://#{TEST_FIXTURE_DIR}/cask/transmission-2.61.dmg"
name "Transmission"
- homepage "https://brew.sh/"
+ homepage "https://transmissionbt.com/"
app "Transmission.app"
end
--
GitLab