From e547438ff43426e31dac3ef070b2feecd8a4621b Mon Sep 17 00:00:00 2001 From: Xu Cheng <xucheng@me.com> Date: Sun, 8 Feb 2015 23:20:45 +0800 Subject: [PATCH] cmd/info: prevent duplicate dependency display. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Before: $ brew info llvm ==> Dependencies Build: xz 鉁�, xz 鉁�, xz 鉁�, xz 鉁�, xz 鉁�, xz 鉁� $ brew info --json=v1 llvm ... "dependencies":["xz","xz","xz","xz","xz","xz"], ... After $ brew info llvm ==> Dependencies Build: xz 鉁� $ brew info --json=v1 llvm ... "dependencies":["xz"], ... Closes Homebrew/homebrew#36653. Signed-off-by: Mike McQuaid <mike@mikemcquaid.com> --- Library/Homebrew/cmd/info.rb | 2 +- Library/Homebrew/formula.rb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Library/Homebrew/cmd/info.rb b/Library/Homebrew/cmd/info.rb index fd08845c44..a1f903b7b1 100644 --- a/Library/Homebrew/cmd/info.rb +++ b/Library/Homebrew/cmd/info.rb @@ -122,7 +122,7 @@ module Homebrew unless f.deps.empty? ohai "Dependencies" %w{build required recommended optional}.map do |type| - deps = f.deps.send(type) + deps = f.deps.send(type).uniq puts "#{type.capitalize}: #{decorate_dependencies deps}" unless deps.empty? end end diff --git a/Library/Homebrew/formula.rb b/Library/Homebrew/formula.rb index 082a8e80fa..d9004c72ac 100644 --- a/Library/Homebrew/formula.rb +++ b/Library/Homebrew/formula.rb @@ -593,7 +593,7 @@ class Formula "installed" => [], "linked_keg" => (linked_keg.resolved_path.basename.to_s if linked_keg.exist?), "keg_only" => keg_only?, - "dependencies" => deps.map(&:name), + "dependencies" => deps.map(&:name).uniq, "conflicts_with" => conflicts.map(&:name), "caveats" => caveats } -- GitLab