From e26cf3a83f5b955c7d004a5c4e8f2668bbf097de Mon Sep 17 00:00:00 2001
From: Mike McQuaid <mike@mikemcquaid.com>
Date: Sun, 5 Mar 2017 11:42:59 +0100
Subject: [PATCH] Don't check Subversion HTTPS pre-Sierra.
The system Subversion doesn't handle new certificate authorities (e.g.
Let's Encrypt) well enough for this check to be useful.
---
Library/Homebrew/dev-cmd/audit.rb | 3 +--
Library/Homebrew/development_tools.rb | 4 ++++
Library/Homebrew/extend/os/mac/development_tools.rb | 9 ++++++++-
3 files changed, 13 insertions(+), 3 deletions(-)
diff --git a/Library/Homebrew/dev-cmd/audit.rb b/Library/Homebrew/dev-cmd/audit.rb
index a8c18f7b63..f620bbe169 100644
--- a/Library/Homebrew/dev-cmd/audit.rb
+++ b/Library/Homebrew/dev-cmd/audit.rb
@@ -680,8 +680,6 @@ class FormulaAuditor
return unless @online
- # The system Curl is too old and unreliable with HTTPS homepages on
- # Yosemite and below.
return unless DevelopmentTools.curl_handles_most_https_homepages?
if http_content_problem = FormulaAuditor.check_http_content(homepage,
user_agents: [:browser, :default])
@@ -1571,6 +1569,7 @@ class ResourceAuditor
problem "The URL #{url} is not a valid git URL"
end
elsif strategy <= SubversionDownloadStrategy
+ next unless DevelopmentTools.subversion_handles_most_https_certificates?
unless Utils.svn_remote_exists url
problem "The URL #{url} is not a valid svn URL"
end
diff --git a/Library/Homebrew/development_tools.rb b/Library/Homebrew/development_tools.rb
index 625d5ea86b..8f417b082e 100644
--- a/Library/Homebrew/development_tools.rb
+++ b/Library/Homebrew/development_tools.rb
@@ -117,6 +117,10 @@ class DevelopmentTools
def curl_handles_most_https_homepages?
true
end
+
+ def subversion_handles_most_https_certificates?
+ true
+ end
end
end
diff --git a/Library/Homebrew/extend/os/mac/development_tools.rb b/Library/Homebrew/extend/os/mac/development_tools.rb
index 1bb12a3d13..f54c6b8a31 100644
--- a/Library/Homebrew/extend/os/mac/development_tools.rb
+++ b/Library/Homebrew/extend/os/mac/development_tools.rb
@@ -78,8 +78,15 @@ class DevelopmentTools
end
def curl_handles_most_https_homepages?
- # The system Curl is too old for some modern HTTPS homepages on Yosemite.
+ # The system Curl is too old for some modern HTTPS homepages on
+ # older macOS versions.
MacOS.version >= :el_capitan
end
+
+ def subversion_handles_most_https_certificates?
+ # The system Subversion is too old for some HTTPS certificates on
+ # older macOS versions.
+ MacOS.version >= :sierra
+ end
end
end
--
GitLab