diff --git a/Library/Homebrew/dev-cmd/audit.rb b/Library/Homebrew/dev-cmd/audit.rb index a8c18f7b634b16185595734433755c0cd03a41e7..f620bbe169d145c59c2487faa6c19ec537206768 100644 --- a/Library/Homebrew/dev-cmd/audit.rb +++ b/Library/Homebrew/dev-cmd/audit.rb @@ -680,8 +680,6 @@ class FormulaAuditor return unless @online - # The system Curl is too old and unreliable with HTTPS homepages on - # Yosemite and below. return unless DevelopmentTools.curl_handles_most_https_homepages? if http_content_problem = FormulaAuditor.check_http_content(homepage, user_agents: [:browser, :default]) @@ -1571,6 +1569,7 @@ class ResourceAuditor problem "The URL #{url} is not a valid git URL" end elsif strategy <= SubversionDownloadStrategy + next unless DevelopmentTools.subversion_handles_most_https_certificates? unless Utils.svn_remote_exists url problem "The URL #{url} is not a valid svn URL" end diff --git a/Library/Homebrew/development_tools.rb b/Library/Homebrew/development_tools.rb index 625d5ea86b505d4248749f8b31da4239ef164938..8f417b082e7b6fd6e424eb980a58252103e6338a 100644 --- a/Library/Homebrew/development_tools.rb +++ b/Library/Homebrew/development_tools.rb @@ -117,6 +117,10 @@ class DevelopmentTools def curl_handles_most_https_homepages? true end + + def subversion_handles_most_https_certificates? + true + end end end diff --git a/Library/Homebrew/extend/os/mac/development_tools.rb b/Library/Homebrew/extend/os/mac/development_tools.rb index 1bb12a3d13c26acca604822b89b2aa07e337f4fe..f54c6b8a313fb4b6bd192e551ff75a67f9d23b96 100644 --- a/Library/Homebrew/extend/os/mac/development_tools.rb +++ b/Library/Homebrew/extend/os/mac/development_tools.rb @@ -78,8 +78,15 @@ class DevelopmentTools end def curl_handles_most_https_homepages? - # The system Curl is too old for some modern HTTPS homepages on Yosemite. + # The system Curl is too old for some modern HTTPS homepages on + # older macOS versions. MacOS.version >= :el_capitan end + + def subversion_handles_most_https_certificates? + # The system Subversion is too old for some HTTPS certificates on + # older macOS versions. + MacOS.version >= :sierra + end end end