From ca999a81f71842aabfed6164a9bac7db444ec433 Mon Sep 17 00:00:00 2001
From: Issy Long <me@issyl0.co.uk>
Date: Thu, 26 Nov 2020 16:54:21 +0000
Subject: [PATCH] dev-cmd/unbottled: Fail nicely if analytics data can't be
retrieved
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
- When testing `brew unbottled <formula>` this crashed because I, as a
maintainer, have `HOMEBREW_NO_ANALYTICS` set on all my machines to
avoid polluting the analytics with test installs.
```
鉂� brew unbottled
==> Getting formulae...
==> Getting analytics data...
Error: undefined method `[]' for nil:NilClass
/usr/local/Homebrew/Library/Homebrew/dev-cmd/unbottled.rb:89:in `formulae_all_sort_installs_from_args'
/usr/local/Homebrew/Library/Homebrew/dev-cmd/unbottled.rb:49:in `unbottled'
/usr/local/Homebrew/Library/Homebrew/brew.rb:119:in `<main>'
```
---
Library/Homebrew/dev-cmd/unbottled.rb | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/Library/Homebrew/dev-cmd/unbottled.rb b/Library/Homebrew/dev-cmd/unbottled.rb
index f258db7002..8ec75447c3 100644
--- a/Library/Homebrew/dev-cmd/unbottled.rb
+++ b/Library/Homebrew/dev-cmd/unbottled.rb
@@ -86,6 +86,13 @@ module Homebrew
ohai "Getting analytics data..."
analytics = Utils::Analytics.formulae_brew_sh_json("analytics/install/90d.json")
+
+ if analytics.blank?
+ raise UsageError,
+ "default sort by analytics data requires " \
+ "`HOMEBREW_NO_GITHUB_API` and `HOMEBREW_NO_ANALYTICS` to be unset"
+ end
+
formulae = analytics["items"].map do |i|
f = i["formula"].split.first
next if f.include?("/")
--
GitLab