diff --git a/Library/Homebrew/cmd/search.rb b/Library/Homebrew/cmd/search.rb index 20221524a442b51b41cb101159f8146a89580716..110e1559e7575525f59eb11c718abd26a43a6422 100644 --- a/Library/Homebrew/cmd/search.rb +++ b/Library/Homebrew/cmd/search.rb @@ -16,15 +16,12 @@ require "formula" require "missing_formula" require "utils" -require "thread" require "official_taps" require "descriptions" module Homebrew module_function - SEARCH_ERROR_QUEUE = Queue.new - def search if ARGV.empty? puts Formatter.columns(Formula.full_names) @@ -61,8 +58,8 @@ module Homebrew regex = query_regexp(query) local_results = search_formulae(regex) puts Formatter.columns(local_results) unless local_results.empty? - tap_results = search_taps(regex) - puts Formatter.columns(tap_results) unless tap_results.empty? + tap_results = search_taps(query) + puts Formatter.columns(tap_results) if tap_results && !tap_results.empty? if $stdout.tty? count = local_results.length + tap_results.length @@ -75,34 +72,25 @@ module Homebrew puts reason elsif count.zero? puts "No formula found for #{query.inspect}." - begin - GitHub.print_pull_requests_matching(query) - rescue GitHub::Error => e - SEARCH_ERROR_QUEUE << e - end + GitHub.print_pull_requests_matching(query) end end end - if $stdout.tty? - metacharacters = %w[\\ | ( ) [ ] { } ^ $ * + ?] - bad_regex = metacharacters.any? do |char| - ARGV.any? do |arg| - arg.include?(char) && !arg.start_with?("/") - end - end - if !ARGV.empty? && bad_regex - ohai "Did you mean to perform a regular expression search?" - ohai "Surround your query with /slashes/ to search by regex." + return unless $stdout.tty? + return if ARGV.empty? + metacharacters = %w[\\ | ( ) [ ] { } ^ $ * + ?].freeze + return unless metacharacters.any? do |char| + ARGV.any? do |arg| + arg.include?(char) && !arg.start_with?("/") end end - - raise SEARCH_ERROR_QUEUE.pop unless SEARCH_ERROR_QUEUE.empty? + ohai <<-EOS.undent + Did you mean to perform a regular expression search? + Surround your query with /slashes/ to search locally by regex. + EOS end - SEARCHABLE_TAPS = OFFICIAL_TAPS.map { |tap| ["Homebrew", tap] } + - OFFICIAL_CASK_TAPS.map { |tap| ["caskroom", tap] } - def query_regexp(query) case query when %r{^/(.*)/$} then Regexp.new($1) @@ -112,53 +100,22 @@ module Homebrew odie "#{query} is not a valid regex" end - def search_taps(regex_or_string) - SEARCHABLE_TAPS.map do |user, repo| - Thread.new { search_tap(user, repo, regex_or_string) } - end.inject([]) do |results, t| - results.concat(t.value) - end - end - - def search_tap(user, repo, regex_or_string) - regex = regex_or_string.is_a?(String) ? /^#{Regexp.escape(regex_or_string)}$/ : regex_or_string - - if (HOMEBREW_LIBRARY/"Taps/#{user.downcase}/homebrew-#{repo.downcase}").directory? && \ - user != "caskroom" - return [] + def search_taps(query) + valid_dirnames = ["Formula", "HomebrewFormula", "Casks", ".", ""].freeze + q = "user:Homebrew%20user:caskroom%20filename:#{query}" + GitHub.open "https://api.github.com/search/code?q=#{q}" do |json| + json["items"].map do |object| + dirname, filename = File.split(object["path"]) + next unless valid_dirnames.include?(dirname) + user = object["repository"]["owner"]["login"] + user = user.downcase if user == "Homebrew" + repo = object["repository"]["name"].sub(/^homebrew-/, "") + tap = Tap.fetch user, repo + next if tap.installed? + basename = File.basename(filename, ".rb") + "#{user}/#{repo}/#{basename}" + end.compact end - - remote_tap_formulae = Hash.new do |cache, key| - user, repo = key.split("/", 2) - tree = {} - - GitHub.open "https://api.github.com/repos/#{user}/homebrew-#{repo}/git/trees/HEAD?recursive=1" do |json| - json["tree"].each do |object| - next unless object["type"] == "blob" - - subtree, file = File.split(object["path"]) - - if File.extname(file) == ".rb" - tree[subtree] ||= [] - tree[subtree] << file - end - end - end - - paths = tree["Formula"] || tree["HomebrewFormula"] || tree["."] || [] - paths += tree["Casks"] || [] - cache[key] = paths.map { |path| File.basename(path, ".rb") } - end - - names = remote_tap_formulae["#{user}/#{repo}"] - user = user.downcase if user == "Homebrew" # special handling for the Homebrew organization - names.select { |name| name =~ regex }.map { |name| "#{user}/#{repo}/#{name}" } - rescue GitHub::HTTPNotFoundError - opoo "Failed to search tap: #{user}/#{repo}. Please run `brew update`" - [] - rescue GitHub::Error => e - SEARCH_ERROR_QUEUE << e - [] end def search_formulae(regex) diff --git a/Library/Homebrew/test/cmd/search_remote_tap_spec.rb b/Library/Homebrew/test/cmd/search_remote_tap_spec.rb index 99c2cc20b59a397c4cc043a64ac32de94237f70b..be7c20865ab925b490a6324856bc422f61b6c896 100644 --- a/Library/Homebrew/test/cmd/search_remote_tap_spec.rb +++ b/Library/Homebrew/test/cmd/search_remote_tap_spec.rb @@ -1,19 +1,24 @@ require "cmd/search" describe Homebrew do - specify "#search_tap" do + specify "#search_taps" do json_response = { - "tree" => [ + "items" => [ { - "path" => "Formula/not-a-formula.rb", - "type" => "blob", + "path" => "Formula/some-formula.rb", + "repository" => { + "name" => "homebrew-foo", + "owner" => { + "login" => "Homebrew", + }, + }, }, ], } allow(GitHub).to receive(:open).and_yield(json_response) - expect(described_class.search_tap("homebrew", "not-a-tap", "not-a-formula")) - .to eq(["homebrew/not-a-tap/not-a-formula"]) + expect(described_class.search_taps("some-formula")) + .to match(["homebrew/foo/some-formula"]) end end