From b2870c2480744aa7d202c4975e3169b05035f7ed Mon Sep 17 00:00:00 2001
From: Josh Hagins <hagins.josh@gmail.com>
Date: Mon, 24 Oct 2016 09:50:33 -0400
Subject: [PATCH] hbc/qualified_token: use regex captures instead of
String#split
---
Library/Homebrew/cask/lib/hbc/qualified_token.rb | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/Library/Homebrew/cask/lib/hbc/qualified_token.rb b/Library/Homebrew/cask/lib/hbc/qualified_token.rb
index 21fe99682b..09eedef1b3 100644
--- a/Library/Homebrew/cask/lib/hbc/qualified_token.rb
+++ b/Library/Homebrew/cask/lib/hbc/qualified_token.rb
@@ -2,10 +2,8 @@ module Hbc
module QualifiedToken
def self.parse(arg)
return nil unless arg.is_a?(String)
- return nil unless arg.downcase =~ HOMEBREW_TAP_CASK_REGEX
- # eg caskroom/cask/google-chrome
- # per https://github.com/Homebrew/brew/blob/master/docs/brew-tap.md
- user, repo, token = arg.downcase.split("/")
+ return nil unless match = arg.downcase.match(HOMEBREW_TAP_CASK_REGEX)
+ user, repo, token = match.captures
odebug "[user, repo, token] might be [#{user}, #{repo}, #{token}]"
[user, repo, token]
end
--
GitLab