From a836602024146c8f1bf849a068c94f7023bd0f13 Mon Sep 17 00:00:00 2001
From: Jack Nagel <jacknagel@gmail.com>
Date: Sat, 22 Feb 2014 20:17:04 -0500
Subject: [PATCH] create: make conditional more obvious
---
Library/Homebrew/cmd/create.rb | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/Library/Homebrew/cmd/create.rb b/Library/Homebrew/cmd/create.rb
index 9d749d73e1..04ebe5d2ea 100644
--- a/Library/Homebrew/cmd/create.rb
+++ b/Library/Homebrew/cmd/create.rb
@@ -95,6 +95,10 @@ class FormulaCreator
end
end
+ def fetch?
+ !ARGV.include?("--no-fetch")
+ end
+
def generate!
raise "#{path} already exists" if path.exist?
@@ -103,8 +107,7 @@ class FormulaCreator
puts "You'll need to add an explicit 'version' to the formula."
end
- # XXX: why is "and version" here?
- unless ARGV.include? "--no-fetch" and version
+ if fetch? && version
r = Resource.new
r.url, r.version, r.owner = url, version, self
@sha1 = r.fetch.sha1 if r.download_strategy == CurlDownloadStrategy
--
GitLab