From a49f3a8e91df8ccbbd7335deab1853ce395c5be4 Mon Sep 17 00:00:00 2001 From: Martin Afanasjew <martin@afanasjew.de> Date: Mon, 4 Jul 2016 07:19:44 +0200 Subject: [PATCH] style: use RuboCop 0.41.1 (#433) Tweak `Style/NumericLiteralPrefix` cop settings as we're using octal literals a lot (both in formulae and the package manager) for file permissions and aren't ready just yet to transition them to the more beginner-friendly `0o` prefix (instead of the more obscure `0` prefix). --- Library/.rubocop.yml | 4 ++++ Library/Homebrew/cmd/style.rb | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/Library/.rubocop.yml b/Library/.rubocop.yml index c532bede05..74a4889172 100644 --- a/Library/.rubocop.yml +++ b/Library/.rubocop.yml @@ -66,6 +66,10 @@ Style/EmptyLineBetweenDefs: Style/NumericLiterals: Enabled: false +# zero-prefixed octal literals are just too widely used (and mostly understood) +Style/NumericLiteralPrefix: + EnforcedOctalStyle: zero_only + # consistency and readability when faced with string interpolation Style/PercentLiteralDelimiters: PreferredDelimiters: diff --git a/Library/Homebrew/cmd/style.rb b/Library/Homebrew/cmd/style.rb index 2356a031b3..0e756ad0c3 100644 --- a/Library/Homebrew/cmd/style.rb +++ b/Library/Homebrew/cmd/style.rb @@ -47,7 +47,7 @@ module Homebrew def check_style_impl(files, output_type, options = {}) fix = options[:fix] - Homebrew.install_gem_setup_path! "rubocop", "0.40" + Homebrew.install_gem_setup_path! "rubocop", "0.41.1" args = %W[ --force-exclusion -- GitLab