From 8e75e3e043021971b635b6f1de12d1de0b814264 Mon Sep 17 00:00:00 2001
From: Mike McQuaid <mike@mikemcquaid.com>
Date: Tue, 29 Oct 2013 16:22:03 -0400
Subject: [PATCH] doctor: strengthen osx-gcc-installer warning.
We hate it and we should tell people why.
Next step may be blocking it altogether.
---
Library/Homebrew/cmd/doctor.rb | 25 +++++++++++++++++++------
1 file changed, 19 insertions(+), 6 deletions(-)
diff --git a/Library/Homebrew/cmd/doctor.rb b/Library/Homebrew/cmd/doctor.rb
index 63c3265230..d41c539dc3 100644
--- a/Library/Homebrew/cmd/doctor.rb
+++ b/Library/Homebrew/cmd/doctor.rb
@@ -261,13 +261,26 @@ def __check_clt_up_to_date
end
def check_for_osx_gcc_installer
- if (MacOS.version < "10.7" || MacOS::Xcode.version < "4.1") && \
- MacOS.clang_version == "2.1" then <<-EOS.undent
- You have osx-gcc-installer installed.
- Homebrew doesn't support osx-gcc-installer, and it is known to cause
- some builds to fail.
- Please install Xcode #{MacOS::Xcode.latest_version}.
+ if (MacOS.version < "10.7" || MacOS::Xcode.version > "4.1") && \
+ MacOS.clang_version == "2.1"
+ message = <<-EOS.undent
+ You seem to have osx-gcc-installer installed.
+ Homebrew doesn't support osx-gcc-installer. It causes many builds to fail and
+ is an unlicensed distribution of really old Xcode files.
EOS
+ if MacOS.version >= :mavericks
+ message += <<-EOS.undent
+ Please run `xcode-select --install` to install the CLT.
+ EOS
+ elsif MacOS.version >= :lion
+ message += <<-EOS.undent
+ Please install the CLT or Xcode #{MacOS::Xcode.latest_version}.
+ EOS
+ else
+ message += <<-EOS.undent
+ Please install Xcode #{MacOS::Xcode.latest_version}.
+ EOS
+ end
end
end
--
GitLab