From 86cd5d2f249295bef02186098265ec9996f9f421 Mon Sep 17 00:00:00 2001
From: Xu Cheng <xucheng@me.com>
Date: Tue, 17 Feb 2015 18:02:05 +0800
Subject: [PATCH] test-bot: fail fast in check_results
Closes Homebrew/homebrew#36893.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
---
Library/Homebrew/cmd/test-bot.rb | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/Library/Homebrew/cmd/test-bot.rb b/Library/Homebrew/cmd/test-bot.rb
index 9a14787643..2617aee87a 100644
--- a/Library/Homebrew/cmd/test-bot.rb
+++ b/Library/Homebrew/cmd/test-bot.rb
@@ -549,15 +549,13 @@ module Homebrew
end
def check_results
- status = :passed
- steps.each do |step|
+ steps.all? do |step|
case step.status
- when :passed then next
+ when :passed then true
when :running then raise
- when :failed then status = :failed
+ when :failed then false
end
end
- status == :passed
end
def formulae
--
GitLab