diff --git a/Library/Homebrew/cask/cmd/upgrade.rb b/Library/Homebrew/cask/cmd/upgrade.rb index 948d97e74abbf29bc4c7c680ff1b619020e66b89..77529012b994e3d17c3202f20b7963c015578b0b 100644 --- a/Library/Homebrew/cask/cmd/upgrade.rb +++ b/Library/Homebrew/cask/cmd/upgrade.rb @@ -42,16 +42,14 @@ module Cask .map { |(old_cask, new_cask)| "#{new_cask.full_name} #{old_cask.version} -> #{new_cask.version}" } .join(", ") - if dry_run? - puts "Dry run: did not upgrade anything." - else - upgradable_casks.each do |(old_cask, new_cask)| - begin - upgrade_cask(old_cask, new_cask) - rescue CaskError => e - caught_exceptions << e - next - end + return puts "Dry run: did not upgrade anything." if dry_run? + + upgradable_casks.each do |(old_cask, new_cask)| + begin + upgrade_cask(old_cask, new_cask) + rescue CaskError => e + caught_exceptions << e + next end end diff --git a/Library/Homebrew/cmd/upgrade.rb b/Library/Homebrew/cmd/upgrade.rb index 854035dd950a8bc388c3313b1d3510efb311aebf..f0acf672fbabb4eec7631823c00e8a0e7f08463c 100644 --- a/Library/Homebrew/cmd/upgrade.rb +++ b/Library/Homebrew/cmd/upgrade.rb @@ -106,15 +106,13 @@ module Homebrew puts formulae_upgrades.join(", ") end - if args.dry_run? - puts "Dry run: did not upgrade anything." - else - upgrade_formulae(formulae_to_install) + return puts "Dry run: did not upgrade anything." if args.dry_run? - check_dependents(formulae_to_install) + upgrade_formulae(formulae_to_install) - Homebrew.messages.display_messages - end + check_dependents(formulae_to_install) + + Homebrew.messages.display_messages end def upgrade_formulae(formulae_to_install) diff --git a/Library/Homebrew/test/cmd/upgrade_spec.rb b/Library/Homebrew/test/cmd/upgrade_spec.rb index a4e13ccb71ff1847eac21b0d65a70f278d4c1c3b..9f139fc059ca5e79ceb030c00d1507ee17c5b34d 100644 --- a/Library/Homebrew/test/cmd/upgrade_spec.rb +++ b/Library/Homebrew/test/cmd/upgrade_spec.rb @@ -16,17 +16,4 @@ describe "brew upgrade", :integration_test do expect(HOMEBREW_CELLAR/"testball/0.1").to be_a_directory expect(HOMEBREW_CELLAR/"testball/0.0.1").not_to exist end - - it "can do a dry run upgrade" do - setup_test_formula "testball" - (HOMEBREW_CELLAR/"testball/0.0.1/foo").mkpath - - expect { brew "upgrade", "--dry-run" } - .to output(/Dry run: did not upgrade anything/).to_stdout - .and not_to_output.to_stderr - .and be_a_success - - expect(HOMEBREW_CELLAR/"testball/0.1").not_to exist - expect(HOMEBREW_CELLAR/"testball/0.0.1").to be_a_directory - end end