From 7e578477939a4e5dede2011ef4c43608a320982f Mon Sep 17 00:00:00 2001
From: Jack Nagel <jacknagel@gmail.com>
Date: Fri, 18 Nov 2011 15:22:04 -0600
Subject: [PATCH] audit: check for ARGV.flag? in formulae
We don't want single letter options like '-v' or '-d' to unintentionally
trigger formula-specific options.
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
---
Library/Homebrew/cmd/audit.rb | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/Library/Homebrew/cmd/audit.rb b/Library/Homebrew/cmd/audit.rb
index 0354210817..b9d67bac6d 100755
--- a/Library/Homebrew/cmd/audit.rb
+++ b/Library/Homebrew/cmd/audit.rb
@@ -120,6 +120,11 @@ def audit_formula_text name, text
problems << " * xcodebuild should be passed an explicit \"SYMROOT\""
end if strict?
+ # using ARGV.flag? for formula options is generally a bad thing
+ if text =~ /ARGV\.flag\?/
+ problems << " * Use 'ARGV.include?' instead of 'ARGV.flag?'"
+ end
+
return problems
end
@@ -128,7 +133,7 @@ def audit_formula_options f, text
# Find possible options
options = []
- text.scan(/ARGV\.(include|flag)\?[ ]*\(?(['"])(.+?)\2/) { |m| options << m[2] }
+ text.scan(/ARGV\.include\?[ ]*\(?(['"])(.+?)\1/) { |m| options << m[1] }
options.reject! {|o| o.include? "#"}
options.uniq!
--
GitLab