From 71b6e239d722bd1d444a5c5e2777d61208cc8049 Mon Sep 17 00:00:00 2001
From: Markus Reiter <me@reitermark.us>
Date: Mon, 9 Oct 2017 18:27:02 +0200
Subject: [PATCH] Set RuboCop maximum to current maximum.
---
Library/.rubocop.yml | 16 ++++++++--------
Library/{.auditcops.yml => .rubocop_audit.yml} | 0
Library/Homebrew/.rubocop.yml | 14 ++++++++++----
Library/Homebrew/cmd/style.rb | 2 +-
Library/Homebrew/test/cmd/style_spec.rb | 4 ++--
5 files changed, 21 insertions(+), 15 deletions(-)
rename Library/{.auditcops.yml => .rubocop_audit.yml} (100%)
diff --git a/Library/.rubocop.yml b/Library/.rubocop.yml
index dd6e039b09..8e45668d93 100644
--- a/Library/.rubocop.yml
+++ b/Library/.rubocop.yml
@@ -63,26 +63,26 @@ Metrics/AbcSize:
Max: 250
Metrics/BlockLength:
- Max: 1250
+ Max: 144
Metrics/ClassLength:
- Max: 1500
+ Max: 589
Metrics/CyclomaticComplexity:
Max: 75
Metrics/LineLength:
- Max: 400
+ Max: 324
Metrics/MethodLength:
- Max: 250
+ Max: 222
Metrics/ModuleLength:
CountComments: false
- Exclude:
- - '**/bin/**/*'
- - '**/cmd/**/*'
- - '**/lib/**/*'
+ Max: 367
+
+Metrics/ParameterLists:
+ CountKeywordArgs: false
Metrics/PerceivedComplexity:
Max: 100
diff --git a/Library/.auditcops.yml b/Library/.rubocop_audit.yml
similarity index 100%
rename from Library/.auditcops.yml
rename to Library/.rubocop_audit.yml
diff --git a/Library/Homebrew/.rubocop.yml b/Library/Homebrew/.rubocop.yml
index 1434686432..0e1fb2d041 100644
--- a/Library/Homebrew/.rubocop.yml
+++ b/Library/Homebrew/.rubocop.yml
@@ -25,14 +25,20 @@ Lint/NestedMethodDefinition:
Lint/ParenthesesAsGroupedExpression:
Enabled: true
+Metrics/BlockLength:
+ Max: 1250
+
Metrics/BlockNesting:
Max: 5
-Metrics/ModuleLength:
- Max: 360
+Metrics/ClassLength:
+ Max: 1226
+
+Metrics/LineLength:
+ Max: 244
-Metrics/ParameterLists:
- CountKeywordArgs: false
+Metrics/MethodLength:
+ Max: 195
# we won't change backward compatible method names
Naming/MethodName:
diff --git a/Library/Homebrew/cmd/style.rb b/Library/Homebrew/cmd/style.rb
index 58f430a27d..89484d67d9 100644
--- a/Library/Homebrew/cmd/style.rb
+++ b/Library/Homebrew/cmd/style.rb
@@ -109,7 +109,7 @@ module Homebrew
args << "--config" << HOMEBREW_LIBRARY_PATH/".rubocop.yml"
args << HOMEBREW_LIBRARY_PATH
else
- args << "--config" << HOMEBREW_LIBRARY/".auditcops.yml"
+ args << "--config" << HOMEBREW_LIBRARY/".rubocop_audit.yml"
args += files
end
diff --git a/Library/Homebrew/test/cmd/style_spec.rb b/Library/Homebrew/test/cmd/style_spec.rb
index 4701036f10..9bc8fcab15 100644
--- a/Library/Homebrew/test/cmd/style_spec.rb
+++ b/Library/Homebrew/test/cmd/style_spec.rb
@@ -4,12 +4,12 @@ describe "brew style" do
around(:each) do |example|
begin
FileUtils.ln_s HOMEBREW_LIBRARY_PATH, HOMEBREW_LIBRARY/"Homebrew"
- FileUtils.ln_s HOMEBREW_LIBRARY_PATH.parent/".rubocop.yml", HOMEBREW_LIBRARY/".auditcops.yml"
+ FileUtils.ln_s HOMEBREW_LIBRARY_PATH.parent/".rubocop.yml", HOMEBREW_LIBRARY/".rubocop_audit.yml"
example.run
ensure
FileUtils.rm_f HOMEBREW_LIBRARY/"Homebrew"
- FileUtils.rm_f HOMEBREW_LIBRARY/".auditcops.yml"
+ FileUtils.rm_f HOMEBREW_LIBRARY/".rubocop_audit.yml"
end
end
--
GitLab