diff --git a/Library/Homebrew/cmd/audit.rb b/Library/Homebrew/cmd/audit.rb index 3f3e6f56cfcee6cd3908cc7cea2270f0823bb42d..2d03a8ec3f902056bcde84d22d2f35d779dedd2d 100644 --- a/Library/Homebrew/cmd/audit.rb +++ b/Library/Homebrew/cmd/audit.rb @@ -257,7 +257,7 @@ class FormulaAuditor end # Use new-style archive downloads - urls.select { |u| u =~ %r[https://.*/(?:tar|zip)ball/] and not u =~ %r[\.git$] }.each do |u| + urls.select { |u| u =~ %r[https://.*/(?:tar|zip)ball/] && u !~ %r[\.git$] }.each do |u| problem "Use /archive/ URLs for GitHub tarballs (url is #{u})." end @@ -335,8 +335,7 @@ class FormulaAuditor end def audit_text - # xcodebuild should specify SYMROOT - if text=~ /system\s+['"]xcodebuild/ and not text =~ /SYMROOT=/ + if text =~ /system\s+['"]xcodebuild/ && text !~ /SYMROOT=/ problem "xcodebuild should be passed an explicit \"SYMROOT\"" end end