From 32f7e738ecfd84e1d8a063f9af332fdc320dfb7d Mon Sep 17 00:00:00 2001 From: Martin Afanasjew <martin@afanasjew.de> Date: Thu, 7 Jul 2016 02:14:31 +0200 Subject: [PATCH] download_strategy: ensure fixed commit hash length The length of the commit hash returned for `--short` can vary depending on user configuration. Make sure this works independently of what might have been configured via a user's `.gitconfig`. This also fixes the failing `GitDownloadStrategyTests#test_last_commit` test for such users. --- Library/Homebrew/download_strategy.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Library/Homebrew/download_strategy.rb b/Library/Homebrew/download_strategy.rb index cb94fa38a5..4cb1a185a0 100644 --- a/Library/Homebrew/download_strategy.rb +++ b/Library/Homebrew/download_strategy.rb @@ -592,7 +592,7 @@ class GitDownloadStrategy < VCSDownloadStrategy end def last_commit - Utils.popen_read("git", "--git-dir", git_dir ,"rev-parse", "--short", "HEAD").chomp + Utils.popen_read("git", "--git-dir", git_dir, "rev-parse", "--short=7", "HEAD").chomp end private -- GitLab