From 2b95755afe0a08ed3061c63e5687ee0d4b2847e8 Mon Sep 17 00:00:00 2001
From: Gautham Goli <gauthamgoli@gautham2.local>
Date: Wed, 11 Dec 2019 00:23:51 +0530
Subject: [PATCH] CLI::Args: Make processed_options read-only
---
Library/Homebrew/cli/args.rb | 8 +++++++-
Library/Homebrew/cli/parser.rb | 4 ++--
2 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/Library/Homebrew/cli/args.rb b/Library/Homebrew/cli/args.rb
index a951194e7c..a32c50b01c 100644
--- a/Library/Homebrew/cli/args.rb
+++ b/Library/Homebrew/cli/args.rb
@@ -5,7 +5,7 @@ require "ostruct"
module Homebrew
module CLI
class Args < OpenStruct
- attr_accessor :processed_options, :args_parsed
+ attr_reader :processed_options, :args_parsed
# undefine tap to allow --tap argument
undef tap
@@ -16,6 +16,12 @@ module Homebrew
@processed_options = []
end
+ def freeze_processed_options!(processed_options)
+ @processed_options += processed_options
+ @processed_options.freeze
+ @args_parsed = true
+ end
+
def option_to_name(option)
option.sub(/\A--?/, "")
.tr("-", "_")
diff --git a/Library/Homebrew/cli/parser.rb b/Library/Homebrew/cli/parser.rb
index 7e9b21cd6f..bda488b0c3 100644
--- a/Library/Homebrew/cli/parser.rb
+++ b/Library/Homebrew/cli/parser.rb
@@ -140,10 +140,10 @@ module Homebrew
end
check_constraint_violations
@args[:remaining] = remaining_args
- @args.args_parsed = @args_parsed = true
- @args.processed_options = @processed_options
+ @args.freeze_processed_options!(@processed_options)
Homebrew.args = @args
cmdline_args.freeze
+ @args_parsed = true
@parser
end
--
GitLab