From 2ad43cb1fddbc056d5f5d389e4c24cdb26dfd2d8 Mon Sep 17 00:00:00 2001
From: Dominyk Tiller <dominyktiller@gmail.com>
Date: Fri, 28 Apr 2017 17:37:46 +0100
Subject: [PATCH] audit: formally ban go get usage
There's been an informal ban for a while but let's
be punchier because this crops up still.
---
Library/Homebrew/dev-cmd/audit.rb | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/Library/Homebrew/dev-cmd/audit.rb b/Library/Homebrew/dev-cmd/audit.rb
index b69fbcfb78..7824052074 100644
--- a/Library/Homebrew/dev-cmd/audit.rb
+++ b/Library/Homebrew/dev-cmd/audit.rb
@@ -885,6 +885,10 @@ class FormulaAuditor
problem "Formulae using virtualenvs do not need a `setuptools` resource."
end
+ if text =~ /system\s+['"]go['"],\s+['"]get['"]/
+ problem "Formulae should not use `go get`. If non-vendored resources are required use `go_resource`s."
+ end
+
return unless text.include?('require "language/go"') && !text.include?("go_resource")
problem "require \"language/go\" is unnecessary unless using `go_resource`s"
end
--
GitLab