From 26c71b19f6f715e1f558da1c904aafe6eecebe11 Mon Sep 17 00:00:00 2001
From: Jack Nagel <jacknagel@gmail.com>
Date: Thu, 27 Feb 2014 21:47:38 -0600
Subject: [PATCH] Add audit check for system "xcodebuild"
---
Library/Homebrew/cmd/audit.rb | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/Library/Homebrew/cmd/audit.rb b/Library/Homebrew/cmd/audit.rb
index edeb03d033..3a8aa876f8 100644
--- a/Library/Homebrew/cmd/audit.rb
+++ b/Library/Homebrew/cmd/audit.rb
@@ -296,8 +296,12 @@ class FormulaAuditor
problem "use \"scons *args\" instead of \"system 'scons', *args\""
end
- if text =~ /system\s+['"]xcodebuild/ && text !~ /SYMROOT=/
- problem "xcodebuild should be passed an explicit \"SYMROOT\""
+ if text =~ /system\s+['"]xcodebuild/
+ problem %{use "xcodebuild *args" instead of "system 'xcodebuild', *args"}
+ end
+
+ if text =~ /xcodebuild[ (]["'*]/ && text !~ /SYMROOT=/
+ problem %{xcodebuild should be passed an explicit "SYMROOT"}
end
if text =~ /Formula\.factory\(/
--
GitLab