diff --git a/Library/Homebrew/rubocops/components_order.rb b/Library/Homebrew/rubocops/components_order.rb index 7f6613799c2eb9082a8c761cce22b05eae6773fe..84dba9a9451a774a0ad4a8ba28cd818a298f10f2 100644 --- a/Library/Homebrew/rubocops/components_order.rb +++ b/Library/Homebrew/rubocops/components_order.rb @@ -150,6 +150,8 @@ module RuboCop valid_node ||= child.method_name.to_s == "patch" valid_node ||= child.method_name.to_s == "resource" + valid_node ||= child.method_name.to_s == "deprecate!" + valid_node ||= child.method_name.to_s == "disable!" @offensive_node = on_os_block @offense_source_range = on_os_block.source_range diff --git a/Library/Homebrew/test/rubocops/components_order_spec.rb b/Library/Homebrew/test/rubocops/components_order_spec.rb index 8aa6bfc867b58320058d0f9123fd09652a6054ea..0a925d52cade42cc40bc2f8f3865aacc12650c9b 100644 --- a/Library/Homebrew/test/rubocops/components_order_spec.rb +++ b/Library/Homebrew/test/rubocops/components_order_spec.rb @@ -324,6 +324,7 @@ describe RuboCop::Cop::FormulaAudit::ComponentsOrder do homepage "https://brew.sh" on_macos do + disable! because: :does_not_build depends_on "readline" end @@ -341,6 +342,7 @@ describe RuboCop::Cop::FormulaAudit::ComponentsOrder do homepage "https://brew.sh" on_linux do + deprecate! because: "it's deprecated" depends_on "readline" end