From 0ec47813f10672ab9ef8ce9c2ad5fba0df67634c Mon Sep 17 00:00:00 2001
From: Stefan Sundin <git@stefansundin.com>
Date: Thu, 5 Apr 2018 14:48:35 -0700
Subject: [PATCH] Prevent .curlrc from being loaded.
---
Library/Homebrew/cmd/vendor-install.sh | 1 +
Library/Homebrew/test/utils/curl_spec.rb | 10 ++++++++++
Library/Homebrew/utils/curl.rb | 1 +
3 files changed, 12 insertions(+)
create mode 100644 Library/Homebrew/test/utils/curl_spec.rb
diff --git a/Library/Homebrew/cmd/vendor-install.sh b/Library/Homebrew/cmd/vendor-install.sh
index 8aba2174e5..a97b816c05 100644
--- a/Library/Homebrew/cmd/vendor-install.sh
+++ b/Library/Homebrew/cmd/vendor-install.sh
@@ -48,6 +48,7 @@ fetch() {
local temporary_path
curl_args=(
+ -q # do not load .curlrc (must be the first argument)
--fail
--remote-time
--location
diff --git a/Library/Homebrew/test/utils/curl_spec.rb b/Library/Homebrew/test/utils/curl_spec.rb
new file mode 100644
index 0000000000..65ad173ab9
--- /dev/null
+++ b/Library/Homebrew/test/utils/curl_spec.rb
@@ -0,0 +1,10 @@
+require "utils/curl"
+
+describe "curl" do
+ describe "curl_args" do
+ it "returns -q as the first argument" do
+ # -q must be the first argument according to "man curl"
+ expect(curl_args("foo")[1]).to eq("-q")
+ end
+ end
+end
diff --git a/Library/Homebrew/utils/curl.rb b/Library/Homebrew/utils/curl.rb
index 7b2488ec72..4770dc03b7 100644
--- a/Library/Homebrew/utils/curl.rb
+++ b/Library/Homebrew/utils/curl.rb
@@ -14,6 +14,7 @@ end
def curl_args(*extra_args, show_output: false, user_agent: :default)
args = [
curl_executable.to_s,
+ "-q", # do not load .curlrc (must be the first argument)
"--show-error",
]
--
GitLab