From 0948d2013adba23ecf22b59a2ff61453c2b6f63e Mon Sep 17 00:00:00 2001 From: Mike McQuaid <mike@mikemcquaid.com> Date: Mon, 10 Apr 2017 22:42:57 +0100 Subject: [PATCH] audit: deprecate language module requirements. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Make `brew audit` complain about language module requirements because they provide a crappy user experience compared to vendoring and we鈥檙e not really fixing bugs in them any more. --- Library/Homebrew/dev-cmd/audit.rb | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Library/Homebrew/dev-cmd/audit.rb b/Library/Homebrew/dev-cmd/audit.rb index ba6c3f3334..45ae9201ad 100644 --- a/Library/Homebrew/dev-cmd/audit.rb +++ b/Library/Homebrew/dev-cmd/audit.rb @@ -1021,6 +1021,10 @@ class FormulaAuditor problem ":tex is deprecated." end + if line =~ /depends_on\s+['"].+['"]\s+=>\s+:(lua|perl|python|ruby)(\d*)/ + problem "Formulae should vendor #{$1} modules rather than use `depends_on ... => :#{$1}#{$2}`." + end + # Commented-out depends_on problem "Commented-out dep #{$1}" if line =~ /#\s*depends_on\s+(.+)\s*$/ -- GitLab